Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate accounts onboarding: Add edit mode to the combo card to enable it to disconnect accounts #2660

Open
wants to merge 62 commits into
base: feature/2509-consolidate-google-account-cards
Choose a base branch
from

Disable button if there are no Ads accounts except that the one that …

883d1db
Select commit
Loading
Failed to load commit list.
Open

Consolidate accounts onboarding: Add edit mode to the combo card to enable it to disconnect accounts #2660

Disable button if there are no Ads accounts except that the one that …
883d1db
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 20, 2024 in 0s

61.5% (-0.0%) compared to 64085a0

View this Pull Request on Codecov

61.5% (-0.0%) compared to 64085a0

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 61.5%. Comparing base (64085a0) to head (883d1db).

Files with missing lines Patch % Lines
...src/components/ads-account-select-control/index.js 66.7% 2 Missing ⚠️
js/src/hooks/useGoogleMCAccount.js 0.0% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                               Coverage Diff                               @@
##           feature/2509-consolidate-google-account-cards   #2660     +/-   ##
===============================================================================
- Coverage                                           61.5%   61.5%   -0.0%     
===============================================================================
  Files                                                320     320             
  Lines                                               4934    4941      +7     
  Branches                                            1207    1210      +3     
===============================================================================
+ Hits                                                3036    3040      +4     
- Misses                                              1730    1732      +2     
- Partials                                             168     169      +1     
Files with missing lines Coverage Δ
...src/components/ads-account-select-control/index.js 80.0% <66.7%> (-20.0%) ⬇️
js/src/hooks/useGoogleMCAccount.js 12.5% <0.0%> (-0.8%) ⬇️
---- 🚨 Try these New Features: