Onboarding: Create new ads account.

[ankitrox]

Changes proposed in this Pull Request:

Closes #2603

Replace this with a good description of your changes & reasoning.

Screenshots:

Detailed test instructions.

Note: As this PR also depends on claim card which is being handled in #2582, an integration branch is created to test this feature.

1. Checkout to the integration branch and build. Make sure you are disconnected from all Google accounts.

2. Connect to the Google account with existing Google ads accounts so that the existing ads account is shown.

3. Click on "Or, create a new Google Ads account" link. It should show you the modal.

4. Ensure that clicking on "Cancel" button does nothing.

5. Clicking on "Yes, I want a new account" should create a new account. While creating the new account, you shall see the text "Creating new ads account" in place of existing ads account card.

6. Once the account is created successfully, existing ads account card will disappear and claim card will be shown.

7. Once the ads account is claimed, you shall see the notice Google Ads conversion measurement has been set up for your store. in green color.

8. Existing ads account card will again be shown with the Connected label and the newly created ads account ID in dropdown.

Additional details:

Changelog entry

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.7%. Comparing base (768ce3c) to head (f2aa1c9).
Report is 55 commits behind head on feature/2509-consolidate-google-account-cards.

Additional details and impacted files

@@                              Coverage Diff                              @@
##           feature/2509-consolidate-google-account-cards   #2651   +/-   ##
=============================================================================
  Coverage                                           62.7%   62.7%           
=============================================================================
  Files                                                326     326           
  Lines                                               5166    5166           
  Branches                                            1266    1266           
=============================================================================
  Hits                                                3239    3239           
  Misses                                              1751    1751           
  Partials                                             176     176           

Flag	Coverage Δ
js-unit-tests	62.7% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
js/src/components/account-card/index.js	91.9% <ø> (ø)

[asvinb]

@joemcgill Can you kindly review the changes I made to the PR in the following commit please:
3e2dcbe

Thanks!

[joemcgill]

Found and made a couple small corrections and this is ready for another review.

[ankitguptaindia]

QA/Test Report- ✅

Test Results - The Google Ads new account creation flow, account claiming, new account connection, and onboarding flow when using a new account are working as described in the requirements, and all tests have passed.

Quick Demo:

Recording.946.mp4

[eason9487]

There are three comments about JSDoc that need adjustments, and I believe they don't need a new round of code reviews. I will be approving it in advance.

💡 Please make sure that this PR will be merged after #2644 is merged to avoid code changes being overlapped with #2644.

[eason9487]

Could this PR not include code changes that are not attributed to it? The d074504 commit belongs more to #2644 (be3e8ec).

[joemcgill]

I actually made the commit originally in this PR, since testing all of the claim functionality properly was better when I could create a new account from the same UI, but I agree that functionally it fit more in the PR for the Claim functionality, so I cherry-picked this commit there. Given that the other will be merged first, it should be fine to leave this as is and resolve any merge conflicts after #2644 is merged.

[joemcgill]

Just marking this as needing changes until after #2644 is finalized and merged.

[joemcgill]

I've updated this to resolve conflicts after #2644 was merged.

I then checked the relevant E2E tests in tests/e2e/specs/setup-mc/step-1-accounts.test.js and noticed that the existing tests are broken in the target branch due to the way mocks were being handled. I've fixed this test in f2aa1c9 to confirm those tests are once again passing once this is merged.

Additional improvements to the changed E2E test can be handled in a follow-up PR.