-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update budget recommendation text #2629
Update budget recommendation text #2629
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/2459-campaign-creation-flow #2629 +/- ##
========================================================================
- Coverage 64.7% 62.6% -2.1%
========================================================================
Files 793 319 -474
Lines 22967 5063 -17904
Branches 1231 1232 +1
========================================================================
- Hits 14865 3171 -11694
+ Misses 7929 1718 -6211
- Partials 173 174 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
LGTM @kt-12 |
Changes Look good and working as expected. ✅ Recording.883.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kt-12, the change looks good.
Could you make this PR not include file changes that don't belong to it?
b1f9944
to
b581d13
Compare
@eason9487 I am unsure how those commits ended up here. This was not the case till after 10upCR. I have removed those commits. It's good for WooCr review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
425c6e3
into
feature/2459-campaign-creation-flow
Changes proposed in this Pull Request:
Closes #2600 .
Text updated to reflect the change. Check screenshot.
Screenshots:
Multiple Counties selected
Single country selected
Detailed test instructions:
Additional details:
Changelog entry