Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kickoff MC and Ads account creation #2618

Merged
merged 93 commits into from
Oct 28, 2024
Merged

Kickoff MC and Ads account creation #2618

merged 93 commits into from
Oct 28, 2024

Commits on Sep 18, 2024

  1. Initial structure.

    @ankitrox
    ankitrox committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    1535369 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Use hooks to determine existing accounts.

    @ankitrox
    ankitrox committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    0d7965c View commit details
    Browse the repository at this point in the history

  2. Fix lint.

    @ankitrox
    ankitrox committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    9e9b662 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Fix: CreateAccounts component. 

    Multiple API calls.
    @ankitrox
    ankitrox committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    c5023b6 View commit details
    Browse the repository at this point in the history

  2. Remove redundant props.

    @ankitrox
    ankitrox committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    d41d825 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Remove redundant code.

    @ankitrox
    ankitrox committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    41e6d04 View commit details
    Browse the repository at this point in the history

  2. Introduce hook.

    @ankitrox
    ankitrox committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    6917337 View commit details
    Browse the repository at this point in the history

  3. Fix: Flicker in component due to resolution state.

    @ankitrox
    ankitrox committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    d1b4c77 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Update account creation checks.

    @ankitrox
    ankitrox committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b997713 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Update name for resolved checks property.

    @ankitrox
    ankitrox committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d293f15 View commit details
    Browse the repository at this point in the history

  2. E2E tests.

    @ankitrox
    ankitrox committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9ef6c13 View commit details
    Browse the repository at this point in the history

  3. Move hook to hooks directory.

    @ankitrox
    ankitrox committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    767a906 View commit details
    Browse the repository at this point in the history

  4. Add JS tests for useCreateAccounts hook.

    @ankitrox
    ankitrox committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2de300a View commit details
    Browse the repository at this point in the history

  5. Add indicator style.

    @ankitrox
    ankitrox committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8239b47 View commit details
    Browse the repository at this point in the history

  6. Fix css lint error.

    @ankitrox
    ankitrox committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2e16bf4 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Refactor hook to handle either of the account creation.

    @ankitrox
    ankitrox committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    32b47d5 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. CR feedback - round 2.

    @ankitrox
    ankitrox committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    f55fd1d View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Add CR feedback changes.

    @ankitrox
    ankitrox committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    95fe0cb View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Remove unwanted props.

    @ankitrox
    ankitrox committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    1a24f0d View commit details
    Browse the repository at this point in the history

  2. Use refs to remove no-deps eslint rule.

    @ankitrox
    ankitrox committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    2325d7a View commit details
    Browse the repository at this point in the history

  3. Fix: e2e tests.

    @ankitrox
    ankitrox committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    a0dcb9a View commit details
    Browse the repository at this point in the history

  4. Fix: hook tests.

    @ankitrox
    ankitrox committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ea3a30f View commit details
    Browse the repository at this point in the history

  5. Lint fix.

    @ankitrox
    ankitrox committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    58738f8 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary act in tests.

    @ankitrox
    ankitrox committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    a2b5f19 View commit details
    Browse the repository at this point in the history

  7. Move hooks to relevant component.

    @ankitrox
    ankitrox committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    c4f0d2b View commit details
    Browse the repository at this point in the history

  8. Fix js linting.

    @ankitrox
    ankitrox committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    0d5130f View commit details
    Browse the repository at this point in the history

  9. Load correct scss file in appropriate component.

    @asvinb
    asvinb committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    896c681 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Add connected icon label.

    @ankitrox
    ankitrox committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    1252ac9 View commit details
    Browse the repository at this point in the history

  2. Fix: E2E tests.

    @ankitrox
    ankitrox committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    6d46a02 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature/2509-consolidate-google-account-cards' into fea… 

    …ture/2567-kickoff-mc-ads-account-creation
    @asvinb
    asvinb committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    948acf0 View commit details
    Browse the repository at this point in the history

  4. Fix: Creating account message showing up constantly.

    @ankitrox
    ankitrox committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    2466e3c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'feature/2567-kickoff-mc-ads-account-creation' of https:… 

    …//github.com/woocommerce/google-listings-and-ads into feature/2567-kickoff-mc-ads-account-creation
    @ankitrox
    ankitrox committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    e0d7ea1 View commit details
    Browse the repository at this point in the history

  6. Update filfilrequest utility.

    @ankitrox
    ankitrox committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    11eba1b View commit details
    Browse the repository at this point in the history

  7. Fix: unit test errors.

    @ankitrox
    ankitrox committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    0df9699 View commit details
    Browse the repository at this point in the history

  8. Add E2E test case for connected label.

    @ankitrox
    ankitrox committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    ab0d80d View commit details
    Browse the repository at this point in the history

  9. Remove ambiguous request mocking.

    @ankitrox
    ankitrox committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    f2b3c21 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Remove use of useCallback and redundant code.

    @ankitrox
    ankitrox committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    b1023b6 View commit details
    Browse the repository at this point in the history

  2. Update conditions for rendering.

    @ankitrox
    ankitrox committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    7d343cd View commit details
    Browse the repository at this point in the history

  3. Formatting updates.

    @ankitrox
    ankitrox committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    37859b3 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Remove unused component.

    @ankitrox
    ankitrox committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    298c0f4 View commit details
    Browse the repository at this point in the history

  2. Update property names and description.

    @ankitrox
    ankitrox committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    5ac6cf1 View commit details
    Browse the repository at this point in the history

  3. Add status for MC account mock.

    @ankitrox
    ankitrox committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    d3f4f6f View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Rename constants.

    @ankitrox
    ankitrox committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    60eff85 View commit details
    Browse the repository at this point in the history

  2. Simplify the auto creation hook.

    @ankitrox
    ankitrox committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    bd98116 View commit details
    Browse the repository at this point in the history

  3. Fix: js lint.

    @ankitrox
    ankitrox committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    cb382e8 View commit details
    Browse the repository at this point in the history

  4. Update existing MC accounts check.

    @ankitrox
    ankitrox committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    747097d View commit details
    Browse the repository at this point in the history

  5. Add tests for existing accounts.

    @ankitrox
    ankitrox committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    79eddb9 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary refs.

    @ankitrox
    ankitrox committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    e03d479 View commit details
    Browse the repository at this point in the history

  7. Consolidate useEffect hook into one.

    @ankitrox
    ankitrox committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    3230a8b View commit details
    Browse the repository at this point in the history

  8. Optimize hook to use limited refs.

    @ankitrox
    ankitrox committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    b5e23ff View commit details
    Browse the repository at this point in the history

  9. Remove unused constants.

    @ankitrox
    ankitrox committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    40bd01c View commit details
    Browse the repository at this point in the history

  10. Fix: E2E tests.

    @ankitrox
    ankitrox committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    4e65cd7 View commit details
    Browse the repository at this point in the history

  11. Add hasGoogleMCConnection property in useGoogleMCAccount hook.

    @ankitrox
    ankitrox committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    63c2f7f View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Update doc block.

    @ankitrox
    ankitrox committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    2da86e6 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Refactor to account creation description components.

    @ankitrox
    ankitrox committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    1180ca8 View commit details
    Browse the repository at this point in the history

  2. Add account creation data hook.

    @ankitrox
    ankitrox committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    8393630 View commit details
    Browse the repository at this point in the history

  3. Improve code readability.

    @ankitrox
    ankitrox committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    971497a View commit details
    Browse the repository at this point in the history

  4. Fix: hook tests.

    @ankitrox
    ankitrox committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5d1048c View commit details
    Browse the repository at this point in the history

  5. Replace isCreatingWhichAccount with creatingWhichAccount.

    @ankitrox
    ankitrox committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    1b4cae2 View commit details
    Browse the repository at this point in the history

  6. Use separate state variables.

    @ankitrox
    ankitrox committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    e74287c View commit details
    Browse the repository at this point in the history

  7. Add doc blocks.

    @ankitrox
    ankitrox committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    0cc906e View commit details
    Browse the repository at this point in the history

  8. Add hooks for account creation determination.

    @ankitrox
    ankitrox committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    19a3a34 View commit details
    Browse the repository at this point in the history

  9. Refactor useAutoCreateAdsMCAccounts hook.

    @ankitrox
    ankitrox committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    d3e380e View commit details
    Browse the repository at this point in the history

  10. Rename useAccountCreationData hook to useAccountsData.

    @ankitrox
    ankitrox committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    3561c05 View commit details
    Browse the repository at this point in the history

  11. Fix: tests.

    @ankitrox
    ankitrox committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    8813820 View commit details
    Browse the repository at this point in the history

  12. Remove redundant code.

    @ankitrox
    ankitrox committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    c9b9f2f View commit details
    Browse the repository at this point in the history

  13. Fix: TypeError.

    @ankitrox
    ankitrox committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    85cc699 View commit details
    Browse the repository at this point in the history

  14. Update doc blocks.

    @ankitrox
    ankitrox committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    b62199d View commit details
    Browse the repository at this point in the history

  15. Fix: E2E tests.

    @ankitrox
    ankitrox committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    3c93840 View commit details
    Browse the repository at this point in the history

  16. Fix: E2E.

    @ankitrox
    ankitrox committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    47af5ad View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Add useGoogleAdsAccountReady hook.

    @ankitrox
    ankitrox committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    7937784 View commit details
    Browse the repository at this point in the history

  2. Remove use of context.

    @ankitrox
    ankitrox committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1d86086 View commit details
    Browse the repository at this point in the history

  3. Remove unwanted components.

    @ankitrox
    ankitrox committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    0be881e View commit details
    Browse the repository at this point in the history

  4. Optimize the useAutoCreateAdsMCAccounts hook and fix tests.

    @ankitrox
    ankitrox committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    98808af View commit details
    Browse the repository at this point in the history

  5. Style changes.

    @ankitrox
    ankitrox committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e74b5e3 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary files.

    @ankitrox
    ankitrox committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    38137a3 View commit details
    Browse the repository at this point in the history

  7. Update display account details logic.

    @ankitrox
    ankitrox committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    18256f3 View commit details
    Browse the repository at this point in the history

  8. Add useGoogleMCAccountReady hook.

    @ankitrox
    ankitrox committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    7a9854b View commit details
    Browse the repository at this point in the history

  9. Update account details rendering logic.

    @ankitrox
    ankitrox committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    2859cf5 View commit details
    Browse the repository at this point in the history

  10. Tweak useGoogleMCAccountReady hook

    @joemcgill
    joemcgill authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    7a24be5 View commit details
    Browse the repository at this point in the history

  11. Remove unused constant

    @joemcgill
    joemcgill committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e62562f View commit details
    Browse the repository at this point in the history

  12. Clean up E2E tests for account creation 

    This removes the unnecessary `SetupAdsAccountPage` from the E2E tests, since they were only being used for mocking and both `SetupAdsAccountPage` and `SetUpAccountsPage` extend the same mocking library.
    @joemcgill
    joemcgill committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    bd1f3e3 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Fix: E2E test.

    @ankitrox
    ankitrox committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    56a2e15 View commit details
    Browse the repository at this point in the history

  2. E2E tests changs for new hook.

    @ankitrox
    ankitrox committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    599c2d2 View commit details
    Browse the repository at this point in the history

  3. CR feedback.

    @ankitrox
    ankitrox committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    f3f63fe View commit details
    Browse the repository at this point in the history

  4. Remove redundant code.

    @ankitrox
    ankitrox committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    72434e2 View commit details
    Browse the repository at this point in the history

  5. Fix: JS lint.

    @ankitrox
    ankitrox committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    e00c6e3 View commit details
    Browse the repository at this point in the history

  6. Fix: condition in hook.

    @ankitrox
    ankitrox committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    7f20af7 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. E2E improvements.

    @ankitrox
    ankitrox committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    d363edc View commit details
    Browse the repository at this point in the history

  2. Use E2E mockAdsStatusClaimed function

    @ankitrox
    ankitrox committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    4b8badb View commit details
    Browse the repository at this point in the history

  3. Use mockAdsAccountConnected utility.

    @ankitrox
    ankitrox committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    9137ef6 View commit details
    Browse the repository at this point in the history

  4. Update docblocks.

    @ankitrox
    ankitrox committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    8d381c4 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Update JSDoc.

    @ankitrox
    ankitrox committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    8ab1be0 View commit details
    Browse the repository at this point in the history