Update budget recommendation text #2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/2459-campaign-creation-flow #2629 +/- ##
========================================================================
- Coverage 64.7% 62.6% -2.1%
========================================================================
Files 793 319 -474
Lines 22967 5063 -17904
Branches 1231 1232 +1
========================================================================
- Hits 14865 3171 -11694
+ Misses 7929 1718 -6211
- Partials 173 174 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
asvinb
approved these changes
Sep 30, 2024
|
LGTM @kt-12 |
joemcgill
changed the base branch from
develop
to
feature/2459-campaign-creation-flow
|
Changes Look good and working as expected. ✅ Recording.883.mp4 |
ankitguptaindia
approved these changes
Oct 1, 2024
kt-12
force-pushed
the
enhancement/2600-update-budget-text
branch
from
b1f9944
to
b581d13
Compare
|
@eason9487 I am unsure how those commits ended up here. This was not the case till after 10upCR. I have removed those commits. It's good for WooCr review now. |
joemcgill
merged commit 425c6e3
into
feature/2459-campaign-creation-flow
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes #2600 .
Text updated to reflect the change. Check screenshot.
Screenshots:
Multiple Counties selected
Single country selected
Detailed test instructions:
Additional details:
Changelog entry