-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try: Make code coverage work #1016
Open
lsinger
wants to merge
11
commits into
trunk
Choose a base branch
from
try/fix-codecov
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsinger
force-pushed
the
try/fix-codecov
branch
from
December 11, 2023 13:20
7d64cae
to
3986cf9
Compare
…ings when running under a different version of PHP (e.g. 8.1 for coverage with phpunit 9.5)
Pinging @barryhughes for awareness -- my suspicion right now is that not all |
Good find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to make a few changes to let us use a relatively current and, most importantly, stock phpunit. Other changes I implemented to enable the process suggested by Codecov.
The one change that seems to break about 25 assertions is using the @before and @after annotations instead of magic method names -- but my suspicion is that this is because those method now actually work. Previously we called
parent::setUp
even though the parent class was providing aset_up
method ... and one missing the@before
annotation at that.So the next step here is to see whether the failing assertions actually make sense (as in, whether our expectations are actually correct) or else what is causing the results to be different from what we expect. Maybe the annotated
set_up
andtear_down
methods aren't running properly at all.