Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try: Make code coverage work #1016

Open
wants to merge 11 commits into
base: trunk
Choose a base branch
from
Open

Try: Make code coverage work #1016

wants to merge 11 commits into from

Conversation

lsinger
Copy link
Contributor

@lsinger lsinger commented Dec 11, 2023

I had to make a few changes to let us use a relatively current and, most importantly, stock phpunit. Other changes I implemented to enable the process suggested by Codecov.

The one change that seems to break about 25 assertions is using the @before and @after annotations instead of magic method names -- but my suspicion is that this is because those method now actually work. Previously we called parent::setUp even though the parent class was providing a set_up method ... and one missing the @before annotation at that.

So the next step here is to see whether the failing assertions actually make sense (as in, whether our expectations are actually correct) or else what is causing the results to be different from what we expect. Maybe the annotated set_up and tear_down methods aren't running properly at all.

@lsinger lsinger self-assigned this Dec 11, 2023
@lsinger
Copy link
Contributor Author

lsinger commented Dec 14, 2023

Pinging @barryhughes for awareness -- my suspicion right now is that not all set_up and tear_down methods are running as intended and possibly might never have. I need to focus back on other things for the time being so this PR here is a sort of save point.

@barryhughes
Copy link
Member

Good find!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants