Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storyboarder Aspect Change #2171

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Storyboarder Aspect Change #2171

wants to merge 21 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 16, 2020

Feature description

The Storyboarder aspect change is feature for changing aspect of boards. There is no way to change the board aspect once project is created, this feature allows to change that in settings.

Solution description

The current storyboarder drawing engine doesn't support dynamic aspect change, so the size of layers need to be manually resized. The images which represents layers of boards also need to be resized the main problem is sg images. Resized sg image stretch the actual image so the the headless render was created specific for sg image rendering. For the control of image update and possibility to cancel it the cas(Cancelable Async Flows) is used.

Area affected and ensured

The main aspect change happens in main-window. For the headless-render we created an invisible electron window.

Task

  • Change of Aspect
  • Resize layers
  • Headless-render

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Vlad Stepura seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant