Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a compatibility setting to disable detection of pen eraser mode #1057

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dgervalle
Copy link
Contributor

I have come across a graphic tablet that has a pen without any eraser mode, but that report all pen contact as being done with the eraser button pressed. As a result, all drawings are erasure, which made such tablet unusable with Storyboarder.

This small pull request add a compatibility section to the preferences pane with an option to disable the detection of the pen eraser mode. This setting is later used to prevent such detection in the sketch pane.

I would be grateful if you could integrate this small improvement.
With kind regards,

Denis Gervalle

@audionerd
Copy link
Member

Nice! Thanks for the PR. I'll review this week.

Do you remember which tablet had this problem? Is it something that could be configured in the tablet's settings?

@dgervalle
Copy link
Contributor Author

I got this issue with a Huion tablet, and no, there was no way in the tablet driver to solve the issue, hence this PR. Would be nice if you can integrate it, since I need to patch any update since then.

@audionerd audionerd added this to the V2 milestone Jun 22, 2018
@audionerd audionerd self-assigned this Jun 22, 2018
@audionerd
Copy link
Member

I think it would be more clear to name the preference enableIgnorePointerEraseButtons.

Instead of "Disable detection of the eraser mode of your pen" we could say "Ignore pen buttons" with a hint "Some pen tablet devices always report that their buttons are pressed. Try toggling this if erase mode is always on when you draw."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants