Draft: Add call
and is_callable
to QJSValue
#225
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds the
call
andis_callable
wrappers for QJSValue. Unfortunately, callables cannot be tested without QJSEngine or equivalent.Dependencies
Depends on #224
Help needed
I currently cannot solve these problems:
QmlEngine
, so if you execute all the tests, the new one panics. I see, that the tests, that are usingQmlEngine
are using the mutex, but they are in completely different module, so I have no idea how to use the same mutex, as them.QJSValueList
,QVariantList
andQStringList
. Is there a way to avoid this kind of stuff, maybe using generics and macro?Related issues
#221