Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Add call and is_callable to QJSValue #225

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gikari
Copy link
Contributor

@gikari gikari commented Jan 11, 2022

Summary

This adds the call and is_callable wrappers for QJSValue. Unfortunately, callables cannot be tested without QJSEngine or equivalent.

Dependencies

Depends on #224

Help needed

I currently cannot solve these problems:

  1. There can be only one QmlEngine, so if you execute all the tests, the new one panics. I see, that the tests, that are using QmlEngine are using the mutex, but they are in completely different module, so I have no idea how to use the same mutex, as them.
  2. I really don't like the duplication of the QJSValueList, QVariantList and QStringList. Is there a way to avoid this kind of stuff, maybe using generics and macro?

Related issues

#221

@gikari gikari marked this pull request as draft January 11, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant