-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: uses new method for requesting calendar permissions on iOS 17 #448
Open
KTDevelopment
wants to merge
1
commit into
wmcmahan:master
Choose a base branch
from
KTDevelopment:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alperpacin
referenced
this pull request
in alperpacin/react-native-calendar-events
Mar 1, 2024
…ar permissions on iOS 17
anton-patrushev
suggested changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
our local patch file is also changing a few more methods with explicit separate logic for iOS >=17:
isCalendarAcessGranted
methodcheckPermissions
methodrequestPermissions
method (you already covered that)
you can try to apply this patch file and update the PR
diff --git a/node_modules/react-native-calendar-events/ios/RNCalendarEvents.m b/node_modules/react-native-calendar-events/ios/RNCalendarEvents.m
index a85c013..4d40020 100644
--- a/node_modules/react-native-calendar-events/ios/RNCalendarEvents.m
+++ b/node_modules/react-native-calendar-events/ios/RNCalendarEvents.m
@@ -95,7 +95,11 @@ - (BOOL)isCalendarAccessGranted
{
EKAuthorizationStatus status = [EKEventStore authorizationStatusForEntityType:EKEntityTypeEvent];
- return status == EKAuthorizationStatusAuthorized;
+ if (@available(iOS 17, *)) {
+ return (status == EKAuthorizationStatusFullAccess || status == EKAuthorizationStatusAuthorized);
+ } else {
+ return status == EKAuthorizationStatusAuthorized;
+ }
}
#pragma mark -
@@ -741,19 +745,39 @@ - (NSDictionary *)serializeCalendarEvent:(EKEvent *)event
NSString *status;
EKAuthorizationStatus authStatus = [EKEventStore authorizationStatusForEntityType:EKEntityTypeEvent];
- switch (authStatus) {
- case EKAuthorizationStatusDenied:
- status = @"denied";
- break;
- case EKAuthorizationStatusRestricted:
- status = @"restricted";
- break;
- case EKAuthorizationStatusAuthorized:
- status = @"authorized";
- break;
- default:
- status = @"undetermined";
- break;
+ if (@available(iOS 17, *)) {
+ switch (authStatus) {
+ case EKAuthorizationStatusDenied:
+ status = @"denied";
+ break;
+ case EKAuthorizationStatusRestricted:
+ status = @"restricted";
+ break;
+ case EKAuthorizationStatusFullAccess:
+ status = @"authorized";
+ break;
+ case EKAuthorizationStatusWriteOnly:
+ status = @"writeOnly";
+ break;
+ default:
+ status = @"undetermined";
+ break;
+ }
+ } else {
+ switch (authStatus) {
+ case EKAuthorizationStatusDenied:
+ status = @"denied";
+ break;
+ case EKAuthorizationStatusRestricted:
+ status = @"restricted";
+ break;
+ case EKAuthorizationStatusAuthorized:
+ status = @"authorized";
+ break;
+ default:
+ status = @"undetermined";
+ break;
+ }
}
resolve(status);
@@ -762,12 +786,23 @@ - (NSDictionary *)serializeCalendarEvent:(EKEvent *)event
RCT_EXPORT_METHOD(requestPermissions:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject)
{
[self.eventStore requestAccessToEntityType:EKEntityTypeEvent completion:^(BOOL granted, NSError *error) {
- NSString *status = granted ? @"authorized" : @"denied";
- if (!error) {
- resolve(status);
+ if (@available(iOS 17, *)) {
+ [self.eventStore requestFullAccessToEventsWithCompletion:^(BOOL granted, NSError *error) {
+ NSString *status = granted ? @"authorized" : @"denied";
+ if (!error) {
+ resolve(status);
+ } else {
+ reject(@"error", @"authorization request error", error);
+ }
+ }];
} else {
- reject(@"error", @"authorization request error", error);
- }
+ NSString *status = granted ? @"authorized" : @"denied";
+ if (!error) {
+ resolve(status);
+ } else {
+ reject(@"error", @"authorization request error", error);
+ }
+ }
}];
}
cleitoncsalvagni
approved these changes
May 28, 2024
Any update on it ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue described in
#440
fix was posted by @daxaxelrod