This repository has been archived by the owner on Jan 13, 2024. It is now read-only.
forked from signalapp/zkgroup
-
Notifications
You must be signed in to change notification settings - Fork 0
Whisperfork permanent PR #1
Open
rubdos
wants to merge
72
commits into
master
Choose a base branch
from
whisperfork
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debian has a more stable retention period for pinned dependencies (the version of OpenJDK 8 we were using for Ubuntu is gone already!), and it matches what the Signal-Android repository is doing.
We don't prebuild these anymore; the client is expected to build themselves, installing the appropriate Rust dependencies.
It's causing problems with the new-style iOS build.
These names changed to allow for Node cross-compilation, but the testable jar still supports only one arch per platform.
This required a tweak to the codegen to accept UUID parameters not named 'uuid'.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request permanently tracks the difference between upstream zkgroup and our fork. It is never to be merged, but hopefully made redundant. Discussion and TODO at https://gitlab.com/whisperfish/zkgroup/-/merge_requests/1