Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with GDK Pixbuf crate #10

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

Schmiddiii
Copy link
Collaborator

Not sure what to do about the conversion between i32 (used by gdk_pixbuf) and u32 if that should be an error instead.

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #10 (c688fae) into main (9ed0f0f) will increase coverage by 1.33%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   88.11%   89.45%   +1.33%     
==========================================
  Files           6        6              
  Lines         244      275      +31     
==========================================
+ Hits          215      246      +31     
  Misses         29       29              
Files Changed Coverage Δ
src/lib.rs 96.57% <100.00%> (+0.73%) ⬆️

Copy link
Member

@rubdos rubdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor remarks.

Cargo.toml Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@rubdos rubdos merged commit 86eba96 into whisperfish:main Aug 24, 2023
7 checks passed
@Schmiddiii Schmiddiii deleted the gdk-pixbuf branch August 24, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants