Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEAM REVIEW] WV-481 - IssuesByBallotItemDisplayList collapsing whenever support/oppose button pressed. OfficeItemCompressed refactor. #4170

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

anewgard41
Copy link
Contributor

@anewgard41 anewgard41 commented Nov 14, 2024

What github.com/wevote/WebApp/issues does this fix?

secondary issue pointed out in WV-481

Changes included this pull request?

  • Extracted candidate rendering logic. Moved rendering to new functional component, OneOfficeCandidateList
  • moved logic for determining which candidates to render into the getCandidatesToRender method. This method ensures that only the required number of candidates is passed down to the OneOfficeCandidateList.
  • In this refactor, I am having an issue with the supportStore. After selecting Support for a candidate and then refreshing the page, the Support for that candidate disappears. However when selecting oppose, it remains after refreshing the page.

… render of BallotScrollingContainer outside of OfficeItemCompressed. Simplified state and rendering.
@anewgard41 anewgard41 changed the title WV-481 - IssuesByBallotItemDisplayList collapsing whenever support/oppose button pressed. OfficeItemCompressed refactor. [TEAM REVIEW] WV-481 - IssuesByBallotItemDisplayList collapsing whenever support/oppose button pressed. OfficeItemCompressed refactor. Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant