🐛 fix: support relative paths in inherited social media card #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a page inherits social_media_card from its parent, look for the image in the parent directory before trying the current page path. This fixes the incorrect path resolution when social_media_card is set on a parent page. The template now tries paths in this order: 1. Current page directory 2. Parent directory 3. Absolute path
✅ Deploy Preview for tabi-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
welpo
force-pushed
the
fix/social-media-card-inheritance-path
branch
from
52642fe
to
f47018c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix path resolution for social media card images when the setting is inherited from a parent page. Previously, when a child page inherited
social_media_cardfrom its parent, the template would only look for the image in the child's directory, causing an error. Now it properly checks the parent directory as well.Note:
pathsetsocial_cardsto the root of their section.Related issue
Fixes #392
Changes
templates/partials/social_media_images.html), to keep it maintainableModified the logic to:
The template will now correctly find images when
social_media_cardis inherited from parent pages or sections.Type of change
Checklist
theme.tomlwith a sane default for the featureconfig.tomlcommentstheme.tomlcomments