Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 style: colour scrollbar to match primary colour #430

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

welpo
Copy link
Owner

@welpo welpo commented Nov 14, 2024

Summary

Added scrollbar-color CSS variable to style scrollbars consistently with the theme's primary color. Respects the use of custom CSS / skins.

Related issue

Same goal as #429: theme cohesion.

Changes

Added scrollbar-color: var(--primary-color) transparent; to the global styles for custom scrollbar styling that matches the theme.

Screenshots

scroll

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have made corresponding changes to the documentation:
  • Updated config.toml comments
  • Updated theme.toml comments
  • Updated "Mastering tabi" post in English
  • Updated "Mastering tabi" post in Spanish
  • Updated "Mastering tabi" post in Catalan

@welpo welpo added the enhancement New feature or request label Nov 14, 2024
@welpo welpo merged commit 1cf2732 into main Nov 14, 2024
3 checks passed
@welpo welpo deleted the style/scrollbar-colour branch November 14, 2024 17:12
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit 665c8f2
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/67362f5e12dfc80008a2ca05
😎 Deploy Preview https://deploy-preview-430--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant