Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix: Isso comments in multilingual setups #427

Merged
merged 1 commit into from
Nov 13, 2024
Merged

🐛 fix: Isso comments in multilingual setups #427

merged 1 commit into from
Nov 13, 2024

Conversation

welpo
Copy link
Owner

@welpo welpo commented Nov 13, 2024 •
edited
Loading

Summary

Fixes a variable name collision that was breaking Isso comments in multilingual sites. The series feature introduced in #406 used a global variable named current_path which conflicts with Zola's built-in variable of the same name, used by the Isso comments implementation.

Related issue

Fixes #426

Changes

  • Renamed the series-related variable from current_path to series_path_components to avoid collision with Zola's built-in variable
  • Made the variable name more descriptive of its actual purpose (storing path components for series navigation)
  • Grouped comment logic in page.html

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@welpo
🐛 fix: isso comments in multilingual setups
7055cd2 
Fixes variable name collision with Zola's built-in current_path that was breaking
Isso comments in multilingual sites. Renames the series-related variable to
series_path_components to be more descriptive and avoid the conflict.

Fixes #426
@welpo welpo added the bug Something isn't working label Nov 13, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 13, 2024 •
edited
Loading

✅ Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit 7055cd2
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/6734e70d5634190008368209
😎 Deploy Preview https://deploy-preview-427--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@welpo welpo merged commit bdb1486 into main Nov 13, 2024
6 of 8 checks passed
@welpo welpo deleted the fix/isso-current-path-collision branch November 13, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Variable name collision breaks isso comments in multilingual sites
1 participant
@welpo