Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 refactor(theme.toml) set sane defaults #127

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Conversation

welpo
Copy link
Owner

@welpo welpo commented Aug 30, 2023

This PR sets saner defaults for when settings are missing in a site using tabi but missing certain config.toml values.

For example, a missing extra.email in config.toml would render the theme.toml value of [email protected]. Certain values like these have been commented out.

Also updates the git pre-commit hook to no longer sync the [extra] content of config and theme.toml, but rather compare the number of lines in each section and abort the commit if they don't match.

Fixes issue #125.

@welpo welpo added the enhancement New feature or request label Aug 30, 2023
@welpo welpo merged commit a1378fe into main Aug 30, 2023
1 check passed
@welpo welpo deleted the fix/sane-theme.toml-defaults branch August 30, 2023 00:11
@welpo welpo mentioned this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant