✨ feat: allow setting default theme #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used as fallback when JS is disabled and `theme_switcher` is enabled. If `default_theme` is unset, it defaults to "light". Used as single theme when `theme_switcher` is disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new feature to set a default theme, either as a fallback for users with JavaScript disabled, or for all visitors when the theme switcher is disabled (
theme_switcher = false).Features:
default_theme: Added a new configuration variable,default_theme, that allows users to set a default theme ("light" or "dark").Technical details:
theme_switcherconfiguration remains, allowing dynamic theme switching manually and based on the user's OS-level theme settings.theme_switcheris disabled, the site will strictly use the theme set in thedefault_themevariable.theme_switcheris enabled, the site will display in the theme defined indefault_theme.Additionally, block quotes have been redesigned, and the CSS variables have been simplified.