Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Removing depreciated support & adding new setup changes #16

Merged
merged 6 commits into from
Nov 14, 2024
Merged

Fix: Removing depreciated support & adding new setup changes #16

merged 6 commits into from
Nov 14, 2024

Conversation

vighnesh-wednesday
Copy link
Collaborator

@vighnesh-wednesday vighnesh-wednesday commented Oct 21, 2024 •
edited
Loading

Describe your changes

Issues found:

  1. The docker image used in the CI was depreciated
  2. Glue setup was exporting PYTHONPATH correctly

Fix made:

  1. Added support to directly install whl file in the CI
  2. Added the correct path to the PYTHONPATH, also exported the variables to SOURCE_FILE
  3. Updated the test cases accordingly.

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • New feature / Breaking change
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vighnesh-wednesday vighnesh-wednesday changed the title Fix/setup update Fix: Removing depreciated support & adding new setup changes Oct 21, 2024
@idipanshu idipanshu merged commit 1e8c0d4 into main Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idipanshu idipanshu idipanshu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vighnesh-wednesday @idipanshu