Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add account to CloudwatchMetricsTarget #661

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

MattiasMTS
Copy link
Contributor

What does this do?

Adding the Account parameter to Cloudwatch datasource.

Why is it a good idea?

A CloudWatch monitoring account views data from source accounts so you can centralize monitoring and troubleshooting activities across multiple accounts.

Context

Questions

grafanalib/cloudwatch.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@JamesGibo JamesGibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for your addition
I have updated the doc string which had a typo

@JamesGibo JamesGibo merged commit d4c10e9 into weaveworks:main Jul 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants