chore: Implement tags, refactor exex notification pooler #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charmful0x
reviewed
Nov 18, 2024
| let (sender, mut receiver) = tokio::sync::mpsc::channel(buffer_size); | ||
|
|
||
| let thread = SUPERVISOR_RT.spawn(async move { | ||
| let irys_provider = UploaderProvider::new(None); |
There was a problem hiding this comment.
rename "Irys" references to "arweave"
|
|
||
| let sealed_block_clone = sealed_block.clone(); | ||
|
|
||
| let brotli_borsh = match Self::serialize_block(sealed_block_clone) { |
There was a problem hiding this comment.
"borsh_brotli" var name instead of "brolti_borsh" to follow the logic and naming convention of the Arweave tags as well ("Encoding")
allnil
reviewed
Nov 18, 2024
| @@ -12,5 +12,5 @@ exex-wvm-bigquery.workspace = true | |||
| tracing.workspace = true | |||
| serde_json.workspace = true | |||
There was a problem hiding this comment.
as I understood it's some kind of Ar provider? maybe name crate like this?
and in future we can just add new specific crates which should be in the node internals itself
There was a problem hiding this comment.
just very cautious with packages which have names Ala "common" :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.