-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Toggle .only package #6734
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: SUCCESS
Repo link: Toggle .only
Packages added:
- Toggle .only
Processing package "Toggle .only"
- All checks passed
You cannot use dots in the package's name due to how Python importing works. |
Are you sure @FichteFoll as I have this installed via add github source and everything has been working fine. I think the name field was just a pretty print thing. |
Yes, I am sure. #2524 covers this. Package Control installs the package under the name specified, i.e. it either calls your package |
hmm, I see what you are getting at now. They way I installed it, it use the repo name. Fixing it in just a moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: SUCCESS
Repo link: Toggle only for Tests
Packages added:
- Toggle only for Tests
Processing package "Toggle only for Tests"
- All checks passed
You'll have to fix the package order after the name change: https://travis-ci.org/wbond/package_control_channel/builds/308559511#L675 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: SUCCESS
Repo link: Toggle only for Tests
Packages added:
- Toggle only for Tests
Processing package "Toggle only for Tests"
- All checks passed
I read through the documentation and I still can't quite tell what this package is for. Some specific unit-testing framework? What framework? Is there an existing package for that framework that may provide similar functionality, or to which this functionality could be added? You're creating a global keybinding that applies in every scope. If possible, you should add You're only performing the modification on the first selection. You should probably do it on every selection. (This would also handle the case where there is no selection.) |
I agree with these.
Please address this feedback before we proceed with the merge. |
So If I understand correctly you would like:
I did quite a bit of looking but the other packages (ones related to Mocha or Jasmine - both JS testing) seem to all be related to either running the tests or generating templates. This one doesn't really fit with either as it more a helper for toggle tests on and off that are auto-running in the background somewhere on a file watcher. I'm not sure how to do the context but I can look it up. |
These are the important parts here. If you need any help with that, I can guide you towards documentation or an implementation. |
@CurtisHumphrey ping |
Toggles ".only" on and off of describe and it for test files in javascript