Export ParsedComponents again
#520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouzi
reviewed
Aug 10, 2023
src/index.ts
Outdated
| @@ -2,7 +2,7 @@ import { DebugHandler, DebugConsume } from "./debugging"; | |||
| import * as en from "./locales/en"; | |||
| import { Chrono, Parser, Refiner } from "./chrono"; | |||
| import { ParsingResult } from "./results"; | |||
| import { Component, ParsedResult, ParsingOption, ParsingReference, Meridiem, Weekday } from "./types"; | |||
| import { Component, ParsedComponents, ParsedResult, ParsingOption, ParsingReference, Meridiem, Weekday } from "./types"; | |||
|
|
|||
| export { en, Chrono, Parser, Refiner, ParsingResult }; | |||
There was a problem hiding this comment.
ParsedComponents needs to be exported here.
There was a problem hiding this comment.
Done! Sorry, that's what I get for not cloning and opening it in the IDE... 🤦🏻
SferaDev
commented
Aug 10, 2023
|
Thanks both of you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using the public
ParsedComponentstype, however in feb250d when the interfaces where movedparsing.tsand later totypes.ts,ParsedComponentswas not re-exported again.There are other interfaces that went private with that change, up to you to decide which ones you want to re-export.