-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: emit an event in EventBus upon dial error #1222
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adklempner
force-pushed
the
feat/dial-error-event
branch
2 times, most recently
from
September 19, 2024 05:23
322633b
to
35f4f61
Compare
adklempner
requested review from
richard-ramos and
chaitanyaprem
as code owners
September 19, 2024 05:23
adklempner
force-pushed
the
feat/dial-error-event
branch
3 times, most recently
from
September 19, 2024 20:55
d296d47
to
4bba456
Compare
adklempner
force-pushed
the
feat/dial-error-event
branch
from
September 23, 2024 19:16
2a730ab
to
b4045dc
Compare
adklempner
force-pushed
the
feat/dial-error-event
branch
from
September 23, 2024 20:23
b4045dc
to
0128560
Compare
richard-ramos
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
adklempner
force-pushed
the
feat/dial-error-event
branch
from
September 23, 2024 21:12
0128560
to
435c1b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upon error dialing in
PeerConnectionStrategy.dialPeer
orWakuNode.connect
, emit aDialError
event. This allows consumers ofgo-waku
to subscribe to a channel which outputs the dial errors as they occur.Changes
DialError
interface in utilsDialError
events toPeerConnectionStrategy
(created inStart()
, closed inStop()
)HandleDialError
toPeerConnectionStrategy
that:DialError
event using the ID of the peer and the returned error message fromc.host.Connect(ctx, pi)
PeerConnectionStrategy.dialPeer
andWakuNode.connect
when an error is returned byhost.Connect
Tests