Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: e2e rel poc - reconnection, new lamport Ts, logging #1220

Merged
merged 1 commit into from
Sep 12, 2024
Merged

feat: e2e rel poc - reconnection, new lamport Ts, logging #1220

merged 1 commit into from
Sep 12, 2024

Conversation

shash256
Copy link
Contributor

@shash256 shash256 commented Sep 12, 2024 •
edited
Loading

Description

This PR add some updates to the e2e reliability POC based on the feedback from dogfooding

Changes

  • new lamport timestamp that is hinted with a wall clock: clock = max(time.Now(), previous_clock+1)
  • disconnect and reconnect commands in chat to better simulate network instability conditions
  • better logging to effectively track causal history, missing messages etc

@shash256 shash256 merged commit bc2444c into master Sep 12, 2024
16 of 17 checks passed
@shash256 shash256 deleted the feat-e2e-rel-updates branch September 12, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm-clius jm-clius jm-clius approved these changes

@richard-ramos richard-ramos Awaiting requested review from richard-ramos richard-ramos is a code owner

@chaitanyaprem chaitanyaprem Awaiting requested review from chaitanyaprem chaitanyaprem is a code owner

Assignees

@shash256 shash256

Labels
None yet
Projects
Waku
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shash256 @jm-clius