chore: move outgoing message check from status-go to go-waku #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaichaosun
requested review from
richard-ramos and
chaitanyaprem
as code owners
richard-ramos
approved these changes
Aug 6, 2024
chaitanyaprem
approved these changes
Aug 6, 2024
kaichaosun
force-pushed
the
move-outgoing-query
branch
from
6566a54
to
2e95798
Compare
|
It seems some un-related test failed, wondering how did you manage to merge the PRs? @chaitanyaprem @richard-ramos |
I used my admin role to override branch protection 😉 |
|
@kaichaosun , issue has been fixed in master thanks to @richard-ramos If you rebase your branch, CI should pass. |
kaichaosun
force-pushed
the
move-outgoing-query
branch
from
2e95798
to
bce7eb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move outgoing message check logic from status-go to go-waku