Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require document to be in scope to be styled by the manifest #791

Closed
wants to merge 4 commits into from

Conversation

mgiuca
Copy link
Collaborator

@mgiuca mgiuca commented Sep 12, 2019

This change (choose one):

  • Breaks existing normative behavior (please add label "breaking")
  • Adds new normative requirements
  • Adds new normative recommendations or optional items
  • Makes only editorial changes (only changes informative sections, or
    changes normative sections without changing behavior)
  • Is a "chore" (metadata, formatting, fixing warnings, etc).

Implementation commitment (delete if not making normative changes):

  • Safari (link to issue)
  • Chrome (link to issue)
  • Firefox (link to issue)
  • Edge (public signal)

Commit message:

Require document to be in scope to be styled by the manifest.

This introduces a small new normative requirement that the manifest NOT be
applied to a document that it outside of its scope. A note explains that this
only applies to the authority of the metadata, not the installation.

Adds a non-normative note that the app can be installed from a document that is
outside the scope of that app.

Closes #784.


Preview | Diff


Preview | Diff

@mgiuca
Copy link
Collaborator Author

mgiuca commented Sep 12, 2019

@dominickng @marcoscaceres Could you look over this language before circulating this more widely.

I think we should seek approval from several vendors on both of the changes included here (both the normative change to ban a manifest from applying to an out-of-scope document, and the explicit decision not to make normative changes to ban manifests from being installable from an out-of-scope document).

Note that this PR is based on #790 so the diff is confusing (come on GitHub please support upstream branches!!!!). Just look at this comparison.

@mgiuca mgiuca force-pushed the doc-out-of-scope branch 2 times, most recently from 6150f8c to 944d443 Compare September 12, 2019 05:36
@dominickng
Copy link
Collaborator

Does it make sense to surface a warning when processing the manifest that the current document URL is out of scope? Otherwise this seems good to me and I think Chrome can align with this behaviour.

@mgiuca
Copy link
Collaborator Author

mgiuca commented Sep 12, 2019

I think if you want to consider this a legitimate use case (as you have argued to me), then we shouldn't show a warning.

If we consider it "bad enough" to show a warning, then I think we should just ban it.

@dominickng
Copy link
Collaborator

This is referring to the change to ban manifests from applying to out of scope documents. The ability to install from an out of scope document to an in-scope document on the same origin wouldn't be what the warning is targeting. But I'm fine with not surfacing a warning in any case.

@mgiuca
Copy link
Collaborator Author

mgiuca commented Sep 13, 2019

This is referring to the change to ban manifests from applying to out of scope documents. The ability to install from an out of scope document to an in-scope document on the same origin wouldn't be what the warning is targeting. But I'm fine with not surfacing a warning in any case.

Hmm, I see. But there would be no way to distinguish a manifest that is designed to be applied for styling (which the warning is intended to target) and one that's intended for installation (which these days is by far the most common usage of Manifest). So there would just be a lot of false warnings to discourage something which we are actually supportive of.

…cope.

This introduces a small new normative requirement that the manifest NOT
be applied to a document that it outside of its scope. A note explains
that this only applies to the authority of the metadata, not the
installation.
…t that is outside the scope of that app.

Closes w3c#784.
@marcoscaceres
Copy link
Member

@mgiuca, what should we do about this PR?

@mgiuca
Copy link
Collaborator Author

mgiuca commented Jun 24, 2020

Hmm, I forgot about this. It might be superseded by #880. I'm waiting for your other PR to land before I tackle #880, so let me get back to this once those land.

@marcoscaceres
Copy link
Member

sounds like a plan.

index.html Outdated Show resolved Hide resolved
Comment on lines +341 to +343
<a>application context</a>, it would immediately start showing the
"out of scope" warning UI (that is recommended in
[[[#navigation-scope]]]). Hence, implementors might wish to avoid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a>application context</a>, it would immediately start showing the
"out of scope" warning UI (that is recommended in
[[[#navigation-scope]]]). Hence, implementors might wish to avoid
<a>application context</a>, it would start exhibiting the
"out of scope" behavior (that is recommended in
[[[#navigation-scope]]]). Hence, implementors might wish to avoid

@marcoscaceres
Copy link
Member

Let's close this one as #1151 landed, and this is covered by that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify behaviour of a page linking to a manifest that is not within scope of that manifest
3 participants