-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require document to be in scope to be styled by the manifest #791
Conversation
@dominickng @marcoscaceres Could you look over this language before circulating this more widely. I think we should seek approval from several vendors on both of the changes included here (both the normative change to ban a manifest from applying to an out-of-scope document, and the explicit decision not to make normative changes to ban manifests from being installable from an out-of-scope document). Note that this PR is based on #790 so the diff is confusing (come on GitHub please support upstream branches!!!!). Just look at this comparison. |
6150f8c
to
944d443
Compare
Does it make sense to surface a warning when processing the manifest that the current document URL is out of scope? Otherwise this seems good to me and I think Chrome can align with this behaviour. |
I think if you want to consider this a legitimate use case (as you have argued to me), then we shouldn't show a warning. If we consider it "bad enough" to show a warning, then I think we should just ban it. |
This is referring to the change to ban manifests from applying to out of scope documents. The ability to install from an out of scope document to an in-scope document on the same origin wouldn't be what the warning is targeting. But I'm fine with not surfacing a warning in any case. |
Hmm, I see. But there would be no way to distinguish a manifest that is designed to be applied for styling (which the warning is intended to target) and one that's intended for installation (which these days is by far the most common usage of Manifest). So there would just be a lot of false warnings to discourage something which we are actually supportive of. |
…cope. This introduces a small new normative requirement that the manifest NOT be applied to a document that it outside of its scope. A note explains that this only applies to the authority of the metadata, not the installation.
…t that is outside the scope of that app. Closes w3c#784.
944d443
to
ebc7550
Compare
@mgiuca, what should we do about this PR? |
sounds like a plan. |
<a>application context</a>, it would immediately start showing the | ||
"out of scope" warning UI (that is recommended in | ||
[[[#navigation-scope]]]). Hence, implementors might wish to avoid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<a>application context</a>, it would immediately start showing the | |
"out of scope" warning UI (that is recommended in | |
[[[#navigation-scope]]]). Hence, implementors might wish to avoid | |
<a>application context</a>, it would start exhibiting the | |
"out of scope" behavior (that is recommended in | |
[[[#navigation-scope]]]). Hence, implementors might wish to avoid |
Let's close this one as #1151 landed, and this is covered by that. |
This change (choose one):
changes normative sections without changing behavior)
Implementation commitment (delete if not making normative changes):
Commit message:
Require document to be in scope to be styled by the manifest.
This introduces a small new normative requirement that the manifest NOT be
applied to a document that it outside of its scope. A note explains that this
only applies to the authority of the metadata, not the installation.
Adds a non-normative note that the app can be installed from a document that is
outside the scope of that app.
Closes #784.
Preview | Diff
Preview | Diff