Use nix

.github/workflows/test.yml

@@ -8,24 +8,10 @@ jobs:
   elm-test:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-
-      - uses: actions/setup-node@v1
-        with:
-          node-version: "12"
-
-      - uses: actions/cache@v2
+      - uses: actions/checkout@v3
+      - uses: cachix/install-nix-action@v22
         with:
-          path: |
-            ~/.npm
-            ~/.elm
-            elm-stuff
-          key: ${{ runner.os }}-cache
-
-      - run: npm install -g [email protected] [email protected] [email protected] [email protected]
-
-      - run: elm-format --validate .
-
-      - run: elm-review
-
-      - run: elm-test
+          github_access_token: ${{ secrets.GITHUB_TOKEN }}
+      - run: nix develop --command elm-format --validate .
+      - run: nix develop --command elm-review
+      - run: nix develop --command elm-test

elm.json

@@ -21,6 +21,6 @@
         "ianmackenzie/elm-units": "2.7.0 <= v < 3.0.0"
     },
     "test-dependencies": {
-        "elm-explorations/test": "1.2.2 <= v < 2.0.0"
+        "elm-explorations/test": "2.2.0 <= v < 3.0.0"
     }
 }

flake.nix

@@ -0,0 +1,22 @@
+{
+  inputs = {
+    nixpkgs.url = "github:NixOS/nixpkgs/nixos-23.11";
+    flake-utils.url = "github:numtide/flake-utils";
+  };
+
+  outputs = { self, nixpkgs, flake-utils }:
+    flake-utils.lib.eachDefaultSystem (system:
+      let pkgs = nixpkgs.legacyPackages.${system};
+      in
+      {
+        devShells.default = with pkgs; with elmPackages; mkShell {
+          buildInputs = [
+            elm
+            elm-format
+            elm-test
+            elm-review
+            elm-json
+          ];
+        };
+      });
+}

review/elm.json

@@ -9,27 +9,27 @@
             "elm/core": "1.0.5",
             "elm/json": "1.1.3",
             "elm/project-metadata-utils": "1.0.1",
-            "jfmengels/elm-review": "2.4.1",
-            "jfmengels/elm-review-simplify": "1.0.1",
-            "jfmengels/elm-review-unused": "1.1.9",
-            "jfmengels/elm-review-performance": "1.0.0",
-            "stil4m/elm-syntax": "7.2.2"
+            "jfmengels/elm-review": "2.13.1",
+            "jfmengels/elm-review-simplify": "2.1.3",
+            "jfmengels/elm-review-unused": "1.2.0",
+            "jfmengels/elm-review-performance": "1.0.2",
+            "stil4m/elm-syntax": "7.3.2"
         },
         "indirect": {
             "elm/html": "1.0.0",
             "elm/parser": "1.1.0",
             "elm/random": "1.0.0",
             "elm/time": "1.0.0",
             "elm/virtual-dom": "1.0.2",
-            "elm-community/list-extra": "8.3.0",
-            "elm-explorations/test": "1.2.2",
+            "elm-community/list-extra": "8.7.0",
+            "elm-explorations/test": "2.2.0",
             "rtfeldman/elm-hex": "1.0.0",
             "stil4m/structured-writer": "1.0.3"
         }
     },
     "test-dependencies": {
         "direct": {
-            "elm-explorations/test": "1.2.2"
+            "elm-explorations/test": "2.2.0"
         },
         "indirect": {}
     }

review/src/ReviewConfig.elm

@@ -34,6 +34,6 @@ config =
     , NoUnused.Parameters.rule
     , NoUnused.Patterns.rule
     , NoUnused.Variables.rule
-    , Simplify.rule
+    , Simplify.rule Simplify.defaults
     , NoUnoptimizedRecursion.rule (NoUnoptimizedRecursion.optOutWithComment "IGNORE TCO")
     ]

scripts/elm-publish.sh

@@ -26,7 +26,7 @@ git commit -m "Bump to $version"
 git push
 last_commit=$(git rev-parse HEAD)
 
-git rm -rf --ignore-unmatch .github benchmarks examples scripts tests elm-physics.gif
+git rm -rf --ignore-unmatch .github benchmarks examples scripts tests elm-physics.gif flake.nix
 sed -i.bak "s+https://unsoundscapes.com/elm-physics/+https://unsoundscapes.com/elm-physics/$version/+g" README.md
 sed -i.bak "s+https://github.com/w0rm/elm-physics/tree/main/+https://github.com/w0rm/elm-physics/tree/$last_commit/+g" README.md
 rm README.md.bak

src/Shapes/Convex.elm

@@ -280,9 +280,11 @@ initFacesHelp visited vertices faceByEdgeIndex facesToCheck edgesToCheck current
         newEdgesToCheck =
             List.foldl
                 (\{ indices } res ->
-                    case indices of
-                        ( i1, i2, i3 ) ->
-                            ( i2, i1 ) :: ( i3, i2 ) :: ( i1, i3 ) :: res
+                    let
+                        ( i1, i2, i3 ) =
+                            indices
+                    in
+                    ( i2, i1 ) :: ( i3, i2 ) :: ( i1, i3 ) :: res
                 )
                 []
                 coplanar

tests/Shapes/ConvexTest.elm

@@ -8,7 +8,6 @@ module Shapes.ConvexTest exposing
     , volume
     )
 
-import Block3d exposing (vertices)
 import Expect
 import Extra.Expect as Expect
 import Fixtures.Convex
@@ -102,8 +101,7 @@ faces =
                 (List.map
                     (\{ normal, vertices } ->
                         \_ ->
-                            Expect.true
-                                "normal points inside"
+                            Expect.equal True
                                 (List.all
                                     (\v ->
                                         let