fix[lang]: stateless modules should not be initialized #4347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyper/semantics/analysis/utils.py
Outdated
Comment on lines
741
to
754
| def is_stateless(module: vy_ast.Module): | ||
| """ | ||
| Determine whether a module is stateless by examining its top-level declarations. | ||
| A module has state if it contains storage variables, transient variables, or | ||
| immutables, or if it includes a "uses" or "initializes" declaration. | ||
| """ | ||
| for i in module.body: | ||
| if isinstance(i, (vy_ast.InitializesDecl, vy_ast.UsesDecl)): | ||
| return False | ||
| if isinstance(i, vy_ast.VariableDecl) and not i.is_constant: | ||
| return False | ||
| if isinstance(i, vy_ast.FunctionDef) and i.name == "__init__": | ||
| return False | ||
| return True |
There was a problem hiding this comment.
i think this belongs better on ModuleT
There was a problem hiding this comment.
Okay, moved it.
vyper/semantics/analysis/module.py
Outdated
| @@ -409,6 +410,10 @@ def visit_InitializesDecl(self, node): | |||
| module_info = get_expr_info(module_ref).module_info | |||
| if module_info is None: | |||
| raise StructureException("Not a module!", module_ref) | |||
| if is_stateless(module_info.module_node): | |||
There was a problem hiding this comment.
maybe should we also have this restriction on UsesDecl -- @cyberthirst wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Forbid
initializeson stateless modules as defined in #4050.How I did it
Define modules with storage variables, transient variables or with
usesandinitializesas stateful.When using
initializeson stateless module, raise exception.How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture