Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useDraggable): img dragging bug #4292

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mnenie
Copy link

@mnenie mnenie commented Oct 21, 2024

resolves #3755

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

So, in this issue, we have a problem related to the handling of img and without preventDefault: true in options we should not have a moving an img. When we set the preventDefault: true in options its work great, but without this, we get a bug that is reproduced in #3755

This pr resolves this bug

Additional context

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 21, 2024
@antfu
Copy link
Member

antfu commented Oct 24, 2024

I am not so sure about the special handling for IMG - it might happend to the other elements as well. I think the best cases would be to have users enable the preventDefaults if they expect that behavior. I would see this is more like a documentation issue - we could improve the docs and guide users to use that options.

Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above

@mnenie
Copy link
Author

mnenie commented Oct 24, 2024

I am not so sure about the special handling for IMG - it might happend to the other elements as well. I think the best cases would be to have users enable the preventDefaults if they expect that behavior. I would see this is more like a documentation issue - we could improve the docs and guide users to use that options.

yea maybe you're right, I'll do it 😉

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Oct 25, 2024
@mnenie mnenie requested a review from antfu October 25, 2024 16:59
@mnenie
Copy link
Author

mnenie commented Oct 25, 2024

As above

@antfu check please, I've added edits to the documentation. I hope this is what we need 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug with useDraggable
2 participants