This repository has been archived by the owner on Apr 23, 2024. It is now read-only.
ENG-171 Run GitGuardian in CI as part of Unified CI in Integrations #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you add the GitGuardian app globally to the org, it only scans code when a PR is opened. This doesn't protect us against the case where someone just creates a branch with plaintext credentials, *but doesn't create a PR*. Adding GitGuardian scans as a GitHub action with a "on push" trigger will make GitGuardian scan all code that appears in the repo, rather than just code which is part of a PR. To make this work, you will need to add GITGUARDIAN_API_KEY GitHub secret in each repository. Organization-wide GitHub secrets apply only on private repositories, so to cover all repos reliably you'll need to create a regular per-repo secret, not an org-wide one.
sethidden
force-pushed
the
ENG-171-gitguardian-ci
branch
from
cf9065f
to
4603499
Compare
Fifciu
approved these changes
Nov 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you add the GitGuardian app globally to the org, it only scans code when a PR is opened. This doesn't protect us against the case where someone just creates a branch with plaintext credentials, but doesn't create a PR.
Adding GitGuardian scans as a GitHub action with a "on push" trigger will make GitGuardian scan all code that appears in the repo, rather than just code which is part of a PR.
To make this work, you will need to add GITGUARDIAN_API_KEY GitHub secret in each repository. Organization-wide GitHub secrets apply only on private repositories, so to cover all repos reliably you'll need to create a regular per-repo secret, not an org-wide one.