Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update koa-router #525

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

diovane-miranda
Copy link

What is the purpose of this pull request?

Update koa-router dependency.

What problem is this solving?

Solve security vulnerability detected by Dependabot.

How should this be manually tested?

Locally link an application that uses node-vtex-api framework, make requests to some endpoints and check if there aren't any error logs.

Screenshots or example usage

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.
  • Chore

Copy link

@fmartins-vtex fmartins-vtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diovane-miranda Theoretically, your changes appear correct.

How are you planning to monitor this change?
Do you have a gradual rollout plan?

I understand that we should prioritize these aspects.

Also, I think that you should mark this PR as "Minor change" instead of "Chore"

Copy link
Contributor

@arturpimentel arturpimentel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

How are you planning to monitor this change?
Do you have a gradual rollout plan?

It's hard to say how that can be monitored, only if we have some way of tracking node-service-runtime's rollouts. Maybe @Jeymisson can help with that. Besides, I believe we usually put rollout plans in our Slack's #defcon channel, where IMOCs will review any critical deploys in VTEX IO, such as this one. But that's a nice thing to keep in mind :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants