Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: next/dynamic ProductShelf Section and internal components. #2559

Open
wants to merge 1 commit into
base: feat/SFS-1512-and-SFS-1513-performance-new-RenderSections-for-all-pages
Choose a base branch
from

Conversation

eduardoformiga
Copy link
Member

@eduardoformiga eduardoformiga commented Nov 12, 2024

What's the purpose of this pull request?

This PR is part of the performance initiative and aims to apply next/dynamic to ProductShelf internal components.

How to test it?

The ProductShelf should render as before.

Starters Deploy Preview

Preview
https://sfj-5f82a4c--starter.preview.vtex.app/

References

POC PR

@eduardoformiga eduardoformiga requested a review from a team as a code owner November 12, 2024 23:09
@eduardoformiga eduardoformiga requested review from hellofanny and pedromtec and removed request for a team November 12, 2024 23:09
Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
faststore-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 11:09pm

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Pull requests related to perfomance issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant