feat: search product control implementations #2547
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tex/faststore into feat/search-product-item-control
ramondorosario-ct
added
enhancement
ramondorosario-ct
requested review from
lucasfp13 and
lariciamota
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ramondorosario-ct
changed the title
| quantity, | ||
| onChangeQuantity: setQuantity, | ||
| // FIXME: Use SKU Matrix component | ||
| skuMatrixControl: <button>Select multiple</button>, |
There was a problem hiding this comment.
Could you use a fs/button instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR is about the implementation of the
Quick Orderfeature. Two other PRs were created, one related to the new SearchProductItemControl component and another handling all the typing.In this PR, the new component, typing, and some logic related to the overall implementation of the feature are brought together. A small adjustment was also made to the useBuyButton hook to prevent the
SliderOverfrom opening when an item is added to the cart.Attention This PR has dependencies on PRs: #2543 and #2546.
ps: Once PR #2543 is merged, the number of changes in this PR will decrease.
Printscreens
ps: the "Select multiple" button is just a regular button used for visualization purposes. Once the SKUMatrix is passed, the SKUMatrix trigger will be displayed.