Allow options in objectToDocumentXML when calling a method #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Allows overriding the InputMessage "Request" element for custom elements based on args param * Options is optional field for objectToDocumentXML function * Replicates `_xml` parameter functionality (sending a custom XML structure as a literal) with JSON arguments.
* Options is optional field for objectToDocumentXML function * Replicates `_xml` parameter functionality (sending a custom XML structure as a literal) with JSON arguments.
…deniche/node-soap into ndeniche_override-base-element
|
@ndeniche please add more tests to cover all scenarios. |
|
i'm closing this in 4 days if there's no more action |
|
All of my new code is covered. Should I improve coverage by adding tests to other features? |
|
@ndeniche if coverage has decreased, then not all the added code has been covered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows overriding the InputMessage "Request" element for custom elements based on args param
objectToDocumentXMLfunction_xmlparameter functionality (sending a custom XML structure as a literal) with JSON arguments.