Add support for playlist files in MPD plugin #1722

[SteveTalbot]

This change to the MPD music service plugin enables Volumio to handle any playlist file format supported by MPD.

This is the fix for issue #1722. Tested and working with M3U playlists on Volumio for Raspberry Pi.

[volumio]

Thanks Steve, for both PRs.
This one will take a while to test for regressions, but it is indeed a very useful PR. Will give it a spin this week

[cwh42]

Any news here?

[BreadPitch]

Any update? Really need this, as this is the feature that decides we use Volumio for playback or not.

[azathoth123]

Agreed. Thing is, it's already done, just needs testing and merge.
I've given up on using the built in web UI for playback. Been using 'mpdroid' app, so much easier.

[BreadPitch]

MPdroid sounds interesting. Can it handle m3u playlists out of the box?

[azathoth123]

Yes it does. I'm used to the days of Winamp where there is always a m3u file in the same folder.

…

On Wed, 18 Sep 2019 at 17:53, BreadPitch ***@***.***> wrote: MPdroid sounds interesting. Can it handle m3u playlists out of the box? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1723?email_source=notifications&email_token=AHQQ26SUFKNP2EGGQT3P7TTQKHM7PA5CNFSM4GZXV7OKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD67FBII#issuecomment-532566177>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHQQ26XMAYYYLGSSNPNT6WLQKHM7PANCNFSM4GZXV7OA> .

[SteveTalbot]

MPD can handle m3u and other playlist formats out of the box, so any MPD client that supports playlists should be able to control playback of an mp3 collection with m3u files in the same directories. The change I made was to add support for playlists in the Volumio web interface.

@volumio: Is there anything I can do to help get this merged?

[volumio]

@SteveTalbot Hi Steve, thanks. Yes, first thing is to handle the conflicts, so I can test it. thanks!

[SteveTalbot]

Hey @volumio, sorry for the delay in turning this around. I've done the merge and updated the PR

[volumio]

Hi @SteveTalbot, gave it a spin.
See my remarks ( I want to move forward with this, but need some more work):

• Please refactor the PR in a way the changes are minimal, I spotted many removals\additions which will break things.
• You've removed the iso playback facility, which we need (it's a feature used on some OEM builds):

If you can reduce the changes, and circumstantiate them only to handling playlists, I can move forward. Thanks

[SteveTalbot]

From memory, MPD returns info about the tracks in an ISO file in a similar format to a playlist. I refactored the code to handle this into a single "parseMpdCommandResponse" function, which should work for ISOs and playlists. So the change probably looks bigger than it is.

Have I inadvertently removed or changed some functionality that's being called from outside the plugin? I tried to keep the external interface the same, but I wanted to make a change that would support all playlist/container formats recognized by MPD.

[volumio]

@SteveTalbot sorry if I ask you to refactor, but from this PR is very hard to spot possible regressions. Please redo it in a very circumstantiated way that handles only playlist cases. Thanks for understanding

[SteveTalbot]

Hi @volumio, I've refactored the changes so it should be easier for you to spot regressions. Can you give it another look please?

[mikelowndes]

This does not seem to have been implemented - what gives?