Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[velero] add extraArgs to Velero node agent configuration #593

Merged

Conversation

simoncampion
Copy link

Special notes for your reviewer:

Currently, the Helm chart does not allow passing command line parameters such as --data-mover-prepare-timeout=1h to the node agent, if I see correctly. This PR adds this option.

Checklist

  • DCO signed
  • Chart Version bumped, please refer to the chart version instruction
  • Variables are documented in the values.yaml or README.md
  • Title of the PR starts with chart name (e.g. [velero])

jenting
jenting previously approved these changes Jun 24, 2024
Copy link
Collaborator

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jenting
Copy link
Collaborator

jenting commented Jun 25, 2024

Could you please help resolve the conflict? Thanks

@simoncampion
Copy link
Author

Could you please help resolve the conflict? Thanks

Sure! I rebased onto main.

Copy link
Collaborator

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@jenting jenting merged commit bb88989 into vmware-tanzu:main Jun 27, 2024
14 checks passed
renovate bot referenced this pull request in teutonet/teutonet-helm-charts Jul 31, 2024
…1023)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [velero](https://togithub.com/vmware-tanzu/velero)
([source](https://togithub.com/vmware-tanzu/helm-charts)) | major |
`6.7.0` -> `7.1.4` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>vmware-tanzu/helm-charts (velero)</summary>

###
[`v7.1.4`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-7.1.4)

[Compare
Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-7.1.3...velero-7.1.4)

A Helm chart for velero

#### What's Changed

- \[velero] Fix maintenance Job resource requests by
[@&#8203;yaraskm](https://togithub.com/yaraskm) in
[https://github.com/vmware-tanzu/helm-charts/pull/610](https://togithub.com/vmware-tanzu/helm-charts/pull/610)

#### New Contributors

- [@&#8203;yaraskm](https://togithub.com/yaraskm) made their first
contribution in
[https://github.com/vmware-tanzu/helm-charts/pull/610](https://togithub.com/vmware-tanzu/helm-charts/pull/610)

**Full Changelog**:
vmware-tanzu/helm-charts@velero-7.1.3...velero-7.1.4

###
[`v7.1.3`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-7.1.3)

[Compare
Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-7.1.2...velero-7.1.3)

A Helm chart for velero

#### What's Changed

- \[velero] feat: Adds --keep-latest-jobs-count for repository
maintenance job by [@&#8203;navilg](https://togithub.com/navilg) in
[https://github.com/vmware-tanzu/helm-charts/pull/604](https://togithub.com/vmware-tanzu/helm-charts/pull/604)

#### New Contributors

- [@&#8203;navilg](https://togithub.com/navilg) made their first
contribution in
[https://github.com/vmware-tanzu/helm-charts/pull/604](https://togithub.com/vmware-tanzu/helm-charts/pull/604)

**Full Changelog**:
vmware-tanzu/helm-charts@velero-7.1.2...velero-7.1.3

###
[`v7.1.2`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-7.1.2)

[Compare
Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-7.1.1...velero-7.1.2)

A Helm chart for velero

#### What's Changed

- \[velero] feat: Adds resources and limits for repository maintenance
job by [@&#8203;Sebastian-RG](https://togithub.com/Sebastian-RG) in
[https://github.com/vmware-tanzu/helm-charts/pull/602](https://togithub.com/vmware-tanzu/helm-charts/pull/602)

**Full Changelog**:
vmware-tanzu/helm-charts@velero-7.1.1...velero-7.1.2

###
[`v7.1.1`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-7.1.1)

[Compare
Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-7.1.0...velero-7.1.1)

A Helm chart for velero

#### What's Changed

- \[velero] fix imagePullSecrets to velero server serviceaccount
[#&#8203;595](https://togithub.com/vmware-tanzu/helm-charts/issues/595)
by [@&#8203;adonispd](https://togithub.com/adonispd) in
[https://github.com/vmware-tanzu/helm-charts/pull/596](https://togithub.com/vmware-tanzu/helm-charts/pull/596)

#### New Contributors

- [@&#8203;adonispd](https://togithub.com/adonispd) made their first
contribution in
[https://github.com/vmware-tanzu/helm-charts/pull/596](https://togithub.com/vmware-tanzu/helm-charts/pull/596)

**Full Changelog**:
vmware-tanzu/helm-charts@velero-7.1.0...velero-7.1.1

###
[`v7.1.0`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-7.1.0)

[Compare
Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-7.0.0...velero-7.1.0)

A Helm chart for velero

#### What's Changed

- \[velero] add extraArgs to Velero node agent configuration by
[@&#8203;simoncampion](https://togithub.com/simoncampion) in
[https://github.com/vmware-tanzu/helm-charts/pull/593](https://togithub.com/vmware-tanzu/helm-charts/pull/593)

#### New Contributors

- [@&#8203;simoncampion](https://togithub.com/simoncampion) made their
first contribution in
[https://github.com/vmware-tanzu/helm-charts/pull/593](https://togithub.com/vmware-tanzu/helm-charts/pull/593)

**Full Changelog**:
vmware-tanzu/helm-charts@velero-7.0.0...velero-7.1.0

###
[`v7.0.0`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-7.0.0)

[Compare
Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-6.7.0...velero-7.0.0)

A Helm chart for velero

#### What's Changed

- \[velero] Bump up Velero 1.14.0 by
[@&#8203;xebia-progress](https://togithub.com/xebia-progress) in
[https://github.com/vmware-tanzu/helm-charts/pull/590](https://togithub.com/vmware-tanzu/helm-charts/pull/590)

#### New Contributors

- [@&#8203;xebia-progress](https://togithub.com/xebia-progress) made
their first contribution in
[https://github.com/vmware-tanzu/helm-charts/pull/590](https://togithub.com/vmware-tanzu/helm-charts/pull/590)

**Full Changelog**:
vmware-tanzu/helm-charts@velero-6.7.0...velero-7.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/teutonet/teutonet-helm-charts).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
mjnagel referenced this pull request in defenseunicorns/uds-core Aug 6, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[cgr.dev/du-uds-defenseunicorns/kubectl-fips](https://edu.chainguard.dev/chainguard/chainguard-images/reference/kubectl-fips/)
([source](https://togithub.com/chainguard-images/images/tree/HEAD/images/kubectl-fips))
| patch | `1.29.5-dev` -> `1.29.7-dev` |
|
[cgr.dev/du-uds-defenseunicorns/velero-fips](https://edu.chainguard.dev/chainguard/chainguard-images/reference/velero-fips/)
([source](https://togithub.com/chainguard-images/images/tree/HEAD/images/velero-fips))
| minor | `1.13.2-dev` -> `1.14.0-dev` |
|
[cgr.dev/du-uds-defenseunicorns/velero-plugin-for-aws-fips](https://edu.chainguard.dev/chainguard/chainguard-images/reference/velero-plugin-for-aws-fips/)
([source](https://togithub.com/chainguard-images/images/tree/HEAD/images/velero-plugin-for-aws-fips))
| minor | `1.9.2` -> `1.10.0` |
| [docker.io/bitnami/kubectl](https://togithub.com/bitnami/containers)
([source](https://togithub.com/bitnami/containers/tree/HEAD/bitnami/kubectl))
| patch | `1.30.2` -> `1.30.3` |
|
[registry1.dso.mil/ironbank/opensource/velero/velero](https://velero.io)
([source](https://repo1.dso.mil/dsop/opensource/velero/velero)) | minor
| `v1.13.2` -> `v1.14.0` |
|
[registry1.dso.mil/ironbank/opensource/velero/velero-plugin-for-aws](https://togithub.com/vmware-tanzu/velero-plugin-for-aws)
([source](https://repo1.dso.mil/dsop/opensource/velero/velero-plugin-for-aws))
| minor | `v1.9.2` -> `v1.10.0` |
| [velero](https://togithub.com/vmware-tanzu/velero)
([source](https://togithub.com/vmware-tanzu/helm-charts)) | major |
`6.6.0` -> `7.1.4` |
| velero/velero | minor | `v1.13.2` -> `v1.14.0` |
|
[velero/velero-plugin-for-aws](https://togithub.com/vmware-tanzu/velero-plugin-for-aws)
| minor | `v1.9.2` -> `v1.10.0` |

---

### Release Notes

<details>
<summary>vmware-tanzu/helm-charts (velero)</summary>

###
[`v7.1.4`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-7.1.4)

[Compare
Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-7.1.3...velero-7.1.4)

A Helm chart for velero

#### What's Changed

- \[velero] Fix maintenance Job resource requests by
[@&#8203;yaraskm](https://togithub.com/yaraskm) in
[https://github.com/vmware-tanzu/helm-charts/pull/610](https://togithub.com/vmware-tanzu/helm-charts/pull/610)

#### New Contributors

- [@&#8203;yaraskm](https://togithub.com/yaraskm) made their first
contribution in
[https://github.com/vmware-tanzu/helm-charts/pull/610](https://togithub.com/vmware-tanzu/helm-charts/pull/610)

**Full Changelog**:
vmware-tanzu/helm-charts@velero-7.1.3...velero-7.1.4

###
[`v7.1.3`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-7.1.3)

[Compare
Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-7.1.2...velero-7.1.3)

A Helm chart for velero

#### What's Changed

- \[velero] feat: Adds --keep-latest-jobs-count for repository
maintenance job by [@&#8203;navilg](https://togithub.com/navilg) in
[https://github.com/vmware-tanzu/helm-charts/pull/604](https://togithub.com/vmware-tanzu/helm-charts/pull/604)

#### New Contributors

- [@&#8203;navilg](https://togithub.com/navilg) made their first
contribution in
[https://github.com/vmware-tanzu/helm-charts/pull/604](https://togithub.com/vmware-tanzu/helm-charts/pull/604)

**Full Changelog**:
vmware-tanzu/helm-charts@velero-7.1.2...velero-7.1.3

###
[`v7.1.2`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-7.1.2)

[Compare
Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-7.1.1...velero-7.1.2)

A Helm chart for velero

#### What's Changed

- \[velero] feat: Adds resources and limits for repository maintenance
job by [@&#8203;Sebastian-RG](https://togithub.com/Sebastian-RG) in
[https://github.com/vmware-tanzu/helm-charts/pull/602](https://togithub.com/vmware-tanzu/helm-charts/pull/602)

**Full Changelog**:
vmware-tanzu/helm-charts@velero-7.1.1...velero-7.1.2

###
[`v7.1.1`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-7.1.1)

[Compare
Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-7.1.0...velero-7.1.1)

A Helm chart for velero

#### What's Changed

- \[velero] fix imagePullSecrets to velero server serviceaccount
[#&#8203;595](https://togithub.com/vmware-tanzu/helm-charts/issues/595)
by [@&#8203;adonispd](https://togithub.com/adonispd) in
[https://github.com/vmware-tanzu/helm-charts/pull/596](https://togithub.com/vmware-tanzu/helm-charts/pull/596)

#### New Contributors

- [@&#8203;adonispd](https://togithub.com/adonispd) made their first
contribution in
[https://github.com/vmware-tanzu/helm-charts/pull/596](https://togithub.com/vmware-tanzu/helm-charts/pull/596)

**Full Changelog**:
vmware-tanzu/helm-charts@velero-7.1.0...velero-7.1.1

###
[`v7.1.0`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-7.1.0)

[Compare
Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-7.0.0...velero-7.1.0)

A Helm chart for velero

#### What's Changed

- \[velero] add extraArgs to Velero node agent configuration by
[@&#8203;simoncampion](https://togithub.com/simoncampion) in
[https://github.com/vmware-tanzu/helm-charts/pull/593](https://togithub.com/vmware-tanzu/helm-charts/pull/593)

#### New Contributors

- [@&#8203;simoncampion](https://togithub.com/simoncampion) made their
first contribution in
[https://github.com/vmware-tanzu/helm-charts/pull/593](https://togithub.com/vmware-tanzu/helm-charts/pull/593)

**Full Changelog**:
vmware-tanzu/helm-charts@velero-7.0.0...velero-7.1.0

###
[`v7.0.0`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-7.0.0)

[Compare
Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-6.7.0...velero-7.0.0)

A Helm chart for velero

#### What's Changed

- \[velero] Bump up Velero 1.14.0 by
[@&#8203;xebia-progress](https://togithub.com/xebia-progress) in
[https://github.com/vmware-tanzu/helm-charts/pull/590](https://togithub.com/vmware-tanzu/helm-charts/pull/590)

#### New Contributors

- [@&#8203;xebia-progress](https://togithub.com/xebia-progress) made
their first contribution in
[https://github.com/vmware-tanzu/helm-charts/pull/590](https://togithub.com/vmware-tanzu/helm-charts/pull/590)

**Full Changelog**:
vmware-tanzu/helm-charts@velero-6.7.0...velero-7.0.0

###
[`v6.7.0`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-6.7.0)

[Compare
Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-6.6.0...velero-6.7.0)

A Helm chart for velero

#### What's Changed

- \[velero] Remove default values for resources by
[@&#8203;rissson](https://togithub.com/rissson) in
[https://github.com/vmware-tanzu/helm-charts/pull/499](https://togithub.com/vmware-tanzu/helm-charts/pull/499)

#### New Contributors

- [@&#8203;rissson](https://togithub.com/rissson) made their first
contribution in
[https://github.com/vmware-tanzu/helm-charts/pull/499](https://togithub.com/vmware-tanzu/helm-charts/pull/499)

**Full Changelog**:
vmware-tanzu/helm-charts@velero-6.6.0...velero-6.7.0

</details>

<details>
<summary>vmware-tanzu/velero-plugin-for-aws
(velero/velero-plugin-for-aws)</summary>

###
[`v1.10.0`](https://togithub.com/vmware-tanzu/velero-plugin-for-aws/releases/tag/v1.10.0):
v1.10

[Compare
Source](https://togithub.com/vmware-tanzu/velero-plugin-for-aws/compare/v1.9.2...v1.10.0)

#### All changes

- Add label
org.opencontainers.image.source([#&#8203;190](https://togithub.com/vmware-tanzu/velero-plugin-for-aws/issues/190),
[@&#8203;robinschneider](https://togithub.com/robinschneider))
- Unset env vars for role-assumption when creds are
set([#&#8203;191](https://togithub.com/vmware-tanzu/velero-plugin-for-aws/issues/191),
[@&#8203;reasonerjt](https://togithub.com/reasonerjt))
- configuration for checksum algorithm for PutObject to
S3([#&#8203;194](https://togithub.com/vmware-tanzu/velero-plugin-for-aws/issues/194),
[@&#8203;reasonerjt](https://togithub.com/reasonerjt))
- Respect the TLS setting in BSL in object store
plugin([#&#8203;195](https://togithub.com/vmware-tanzu/velero-plugin-for-aws/issues/195),
[@&#8203;reasonerjt](https://togithub.com/reasonerjt))
- Bump up to golang
v1.22([#&#8203;199](https://togithub.com/vmware-tanzu/velero-plugin-for-aws/issues/199),
reasonerjt)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/defenseunicorns/uds-core).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Micah Nagel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node-Agent Cannot set --data-mover-prepare-timeout flag
3 participants