-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[velero] add extraArgs to Velero node agent configuration #593
Merged
jenting
merged 1 commit into
vmware-tanzu:main
from
simoncampion:add-velero-node-agent-extra-args
Jun 27, 2024
Merged
[velero] add extraArgs to Velero node agent configuration #593
jenting
merged 1 commit into
vmware-tanzu:main
from
simoncampion:add-velero-node-agent-extra-args
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenting
previously approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Could you please help resolve the conflict? Thanks |
Signed-off-by: Simon Campion <[email protected]>
simoncampion
force-pushed
the
add-velero-node-agent-extra-args
branch
from
June 26, 2024 16:13
ab9d3b9
to
5e02307
Compare
Sure! I rebased onto |
jenting
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
blackpiglet
approved these changes
Jun 27, 2024
renovate bot
referenced
this pull request
in teutonet/teutonet-helm-charts
Jul 31, 2024
…1023) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [velero](https://togithub.com/vmware-tanzu/velero) ([source](https://togithub.com/vmware-tanzu/helm-charts)) | major | `6.7.0` -> `7.1.4` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>vmware-tanzu/helm-charts (velero)</summary> ### [`v7.1.4`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-7.1.4) [Compare Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-7.1.3...velero-7.1.4) A Helm chart for velero #### What's Changed - \[velero] Fix maintenance Job resource requests by [@​yaraskm](https://togithub.com/yaraskm) in [https://github.com/vmware-tanzu/helm-charts/pull/610](https://togithub.com/vmware-tanzu/helm-charts/pull/610) #### New Contributors - [@​yaraskm](https://togithub.com/yaraskm) made their first contribution in [https://github.com/vmware-tanzu/helm-charts/pull/610](https://togithub.com/vmware-tanzu/helm-charts/pull/610) **Full Changelog**: vmware-tanzu/helm-charts@velero-7.1.3...velero-7.1.4 ### [`v7.1.3`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-7.1.3) [Compare Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-7.1.2...velero-7.1.3) A Helm chart for velero #### What's Changed - \[velero] feat: Adds --keep-latest-jobs-count for repository maintenance job by [@​navilg](https://togithub.com/navilg) in [https://github.com/vmware-tanzu/helm-charts/pull/604](https://togithub.com/vmware-tanzu/helm-charts/pull/604) #### New Contributors - [@​navilg](https://togithub.com/navilg) made their first contribution in [https://github.com/vmware-tanzu/helm-charts/pull/604](https://togithub.com/vmware-tanzu/helm-charts/pull/604) **Full Changelog**: vmware-tanzu/helm-charts@velero-7.1.2...velero-7.1.3 ### [`v7.1.2`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-7.1.2) [Compare Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-7.1.1...velero-7.1.2) A Helm chart for velero #### What's Changed - \[velero] feat: Adds resources and limits for repository maintenance job by [@​Sebastian-RG](https://togithub.com/Sebastian-RG) in [https://github.com/vmware-tanzu/helm-charts/pull/602](https://togithub.com/vmware-tanzu/helm-charts/pull/602) **Full Changelog**: vmware-tanzu/helm-charts@velero-7.1.1...velero-7.1.2 ### [`v7.1.1`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-7.1.1) [Compare Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-7.1.0...velero-7.1.1) A Helm chart for velero #### What's Changed - \[velero] fix imagePullSecrets to velero server serviceaccount [#​595](https://togithub.com/vmware-tanzu/helm-charts/issues/595) by [@​adonispd](https://togithub.com/adonispd) in [https://github.com/vmware-tanzu/helm-charts/pull/596](https://togithub.com/vmware-tanzu/helm-charts/pull/596) #### New Contributors - [@​adonispd](https://togithub.com/adonispd) made their first contribution in [https://github.com/vmware-tanzu/helm-charts/pull/596](https://togithub.com/vmware-tanzu/helm-charts/pull/596) **Full Changelog**: vmware-tanzu/helm-charts@velero-7.1.0...velero-7.1.1 ### [`v7.1.0`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-7.1.0) [Compare Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-7.0.0...velero-7.1.0) A Helm chart for velero #### What's Changed - \[velero] add extraArgs to Velero node agent configuration by [@​simoncampion](https://togithub.com/simoncampion) in [https://github.com/vmware-tanzu/helm-charts/pull/593](https://togithub.com/vmware-tanzu/helm-charts/pull/593) #### New Contributors - [@​simoncampion](https://togithub.com/simoncampion) made their first contribution in [https://github.com/vmware-tanzu/helm-charts/pull/593](https://togithub.com/vmware-tanzu/helm-charts/pull/593) **Full Changelog**: vmware-tanzu/helm-charts@velero-7.0.0...velero-7.1.0 ### [`v7.0.0`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-7.0.0) [Compare Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-6.7.0...velero-7.0.0) A Helm chart for velero #### What's Changed - \[velero] Bump up Velero 1.14.0 by [@​xebia-progress](https://togithub.com/xebia-progress) in [https://github.com/vmware-tanzu/helm-charts/pull/590](https://togithub.com/vmware-tanzu/helm-charts/pull/590) #### New Contributors - [@​xebia-progress](https://togithub.com/xebia-progress) made their first contribution in [https://github.com/vmware-tanzu/helm-charts/pull/590](https://togithub.com/vmware-tanzu/helm-charts/pull/590) **Full Changelog**: vmware-tanzu/helm-charts@velero-6.7.0...velero-7.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/teutonet/teutonet-helm-charts). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
mjnagel
referenced
this pull request
in defenseunicorns/uds-core
Aug 6, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cgr.dev/du-uds-defenseunicorns/kubectl-fips](https://edu.chainguard.dev/chainguard/chainguard-images/reference/kubectl-fips/) ([source](https://togithub.com/chainguard-images/images/tree/HEAD/images/kubectl-fips)) | patch | `1.29.5-dev` -> `1.29.7-dev` | | [cgr.dev/du-uds-defenseunicorns/velero-fips](https://edu.chainguard.dev/chainguard/chainguard-images/reference/velero-fips/) ([source](https://togithub.com/chainguard-images/images/tree/HEAD/images/velero-fips)) | minor | `1.13.2-dev` -> `1.14.0-dev` | | [cgr.dev/du-uds-defenseunicorns/velero-plugin-for-aws-fips](https://edu.chainguard.dev/chainguard/chainguard-images/reference/velero-plugin-for-aws-fips/) ([source](https://togithub.com/chainguard-images/images/tree/HEAD/images/velero-plugin-for-aws-fips)) | minor | `1.9.2` -> `1.10.0` | | [docker.io/bitnami/kubectl](https://togithub.com/bitnami/containers) ([source](https://togithub.com/bitnami/containers/tree/HEAD/bitnami/kubectl)) | patch | `1.30.2` -> `1.30.3` | | [registry1.dso.mil/ironbank/opensource/velero/velero](https://velero.io) ([source](https://repo1.dso.mil/dsop/opensource/velero/velero)) | minor | `v1.13.2` -> `v1.14.0` | | [registry1.dso.mil/ironbank/opensource/velero/velero-plugin-for-aws](https://togithub.com/vmware-tanzu/velero-plugin-for-aws) ([source](https://repo1.dso.mil/dsop/opensource/velero/velero-plugin-for-aws)) | minor | `v1.9.2` -> `v1.10.0` | | [velero](https://togithub.com/vmware-tanzu/velero) ([source](https://togithub.com/vmware-tanzu/helm-charts)) | major | `6.6.0` -> `7.1.4` | | velero/velero | minor | `v1.13.2` -> `v1.14.0` | | [velero/velero-plugin-for-aws](https://togithub.com/vmware-tanzu/velero-plugin-for-aws) | minor | `v1.9.2` -> `v1.10.0` | --- ### Release Notes <details> <summary>vmware-tanzu/helm-charts (velero)</summary> ### [`v7.1.4`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-7.1.4) [Compare Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-7.1.3...velero-7.1.4) A Helm chart for velero #### What's Changed - \[velero] Fix maintenance Job resource requests by [@​yaraskm](https://togithub.com/yaraskm) in [https://github.com/vmware-tanzu/helm-charts/pull/610](https://togithub.com/vmware-tanzu/helm-charts/pull/610) #### New Contributors - [@​yaraskm](https://togithub.com/yaraskm) made their first contribution in [https://github.com/vmware-tanzu/helm-charts/pull/610](https://togithub.com/vmware-tanzu/helm-charts/pull/610) **Full Changelog**: vmware-tanzu/helm-charts@velero-7.1.3...velero-7.1.4 ### [`v7.1.3`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-7.1.3) [Compare Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-7.1.2...velero-7.1.3) A Helm chart for velero #### What's Changed - \[velero] feat: Adds --keep-latest-jobs-count for repository maintenance job by [@​navilg](https://togithub.com/navilg) in [https://github.com/vmware-tanzu/helm-charts/pull/604](https://togithub.com/vmware-tanzu/helm-charts/pull/604) #### New Contributors - [@​navilg](https://togithub.com/navilg) made their first contribution in [https://github.com/vmware-tanzu/helm-charts/pull/604](https://togithub.com/vmware-tanzu/helm-charts/pull/604) **Full Changelog**: vmware-tanzu/helm-charts@velero-7.1.2...velero-7.1.3 ### [`v7.1.2`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-7.1.2) [Compare Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-7.1.1...velero-7.1.2) A Helm chart for velero #### What's Changed - \[velero] feat: Adds resources and limits for repository maintenance job by [@​Sebastian-RG](https://togithub.com/Sebastian-RG) in [https://github.com/vmware-tanzu/helm-charts/pull/602](https://togithub.com/vmware-tanzu/helm-charts/pull/602) **Full Changelog**: vmware-tanzu/helm-charts@velero-7.1.1...velero-7.1.2 ### [`v7.1.1`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-7.1.1) [Compare Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-7.1.0...velero-7.1.1) A Helm chart for velero #### What's Changed - \[velero] fix imagePullSecrets to velero server serviceaccount [#​595](https://togithub.com/vmware-tanzu/helm-charts/issues/595) by [@​adonispd](https://togithub.com/adonispd) in [https://github.com/vmware-tanzu/helm-charts/pull/596](https://togithub.com/vmware-tanzu/helm-charts/pull/596) #### New Contributors - [@​adonispd](https://togithub.com/adonispd) made their first contribution in [https://github.com/vmware-tanzu/helm-charts/pull/596](https://togithub.com/vmware-tanzu/helm-charts/pull/596) **Full Changelog**: vmware-tanzu/helm-charts@velero-7.1.0...velero-7.1.1 ### [`v7.1.0`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-7.1.0) [Compare Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-7.0.0...velero-7.1.0) A Helm chart for velero #### What's Changed - \[velero] add extraArgs to Velero node agent configuration by [@​simoncampion](https://togithub.com/simoncampion) in [https://github.com/vmware-tanzu/helm-charts/pull/593](https://togithub.com/vmware-tanzu/helm-charts/pull/593) #### New Contributors - [@​simoncampion](https://togithub.com/simoncampion) made their first contribution in [https://github.com/vmware-tanzu/helm-charts/pull/593](https://togithub.com/vmware-tanzu/helm-charts/pull/593) **Full Changelog**: vmware-tanzu/helm-charts@velero-7.0.0...velero-7.1.0 ### [`v7.0.0`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-7.0.0) [Compare Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-6.7.0...velero-7.0.0) A Helm chart for velero #### What's Changed - \[velero] Bump up Velero 1.14.0 by [@​xebia-progress](https://togithub.com/xebia-progress) in [https://github.com/vmware-tanzu/helm-charts/pull/590](https://togithub.com/vmware-tanzu/helm-charts/pull/590) #### New Contributors - [@​xebia-progress](https://togithub.com/xebia-progress) made their first contribution in [https://github.com/vmware-tanzu/helm-charts/pull/590](https://togithub.com/vmware-tanzu/helm-charts/pull/590) **Full Changelog**: vmware-tanzu/helm-charts@velero-6.7.0...velero-7.0.0 ### [`v6.7.0`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-6.7.0) [Compare Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-6.6.0...velero-6.7.0) A Helm chart for velero #### What's Changed - \[velero] Remove default values for resources by [@​rissson](https://togithub.com/rissson) in [https://github.com/vmware-tanzu/helm-charts/pull/499](https://togithub.com/vmware-tanzu/helm-charts/pull/499) #### New Contributors - [@​rissson](https://togithub.com/rissson) made their first contribution in [https://github.com/vmware-tanzu/helm-charts/pull/499](https://togithub.com/vmware-tanzu/helm-charts/pull/499) **Full Changelog**: vmware-tanzu/helm-charts@velero-6.6.0...velero-6.7.0 </details> <details> <summary>vmware-tanzu/velero-plugin-for-aws (velero/velero-plugin-for-aws)</summary> ### [`v1.10.0`](https://togithub.com/vmware-tanzu/velero-plugin-for-aws/releases/tag/v1.10.0): v1.10 [Compare Source](https://togithub.com/vmware-tanzu/velero-plugin-for-aws/compare/v1.9.2...v1.10.0) #### All changes - Add label org.opencontainers.image.source([#​190](https://togithub.com/vmware-tanzu/velero-plugin-for-aws/issues/190), [@​robinschneider](https://togithub.com/robinschneider)) - Unset env vars for role-assumption when creds are set([#​191](https://togithub.com/vmware-tanzu/velero-plugin-for-aws/issues/191), [@​reasonerjt](https://togithub.com/reasonerjt)) - configuration for checksum algorithm for PutObject to S3([#​194](https://togithub.com/vmware-tanzu/velero-plugin-for-aws/issues/194), [@​reasonerjt](https://togithub.com/reasonerjt)) - Respect the TLS setting in BSL in object store plugin([#​195](https://togithub.com/vmware-tanzu/velero-plugin-for-aws/issues/195), [@​reasonerjt](https://togithub.com/reasonerjt)) - Bump up to golang v1.22([#​199](https://togithub.com/vmware-tanzu/velero-plugin-for-aws/issues/199), reasonerjt) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/defenseunicorns/uds-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Micah Nagel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special notes for your reviewer:
Currently, the Helm chart does not allow passing command line parameters such as
--data-mover-prepare-timeout=1h
to the node agent, if I see correctly. This PR adds this option.Checklist
[velero]
)