Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[velero] Added default operation timeout override #546

Conversation

DreamingRaven
Copy link
Contributor

@DreamingRaven DreamingRaven commented Feb 8, 2024

Special notes for your reviewer:

This adds the ability to set the default operation timeout, an incredibly small and backwards compatible change that is important for large volume backups via schedules which have no other means to override this option.

resolves #545

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the values.yaml or README.md
  • Title of the PR starts with chart name (e.g. [velero])

@DreamingRaven DreamingRaven force-pushed the feature-default-item-operation-timeout branch from d37c592 to d4b55e0 Compare February 8, 2024 22:30
@DreamingRaven
Copy link
Contributor Author

Hey just a ping to see if I can get this moving again.

Copy link
Collaborator

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiuming-best qiuming-best merged commit 64ef5b1 into vmware-tanzu:main Feb 21, 2024
13 checks passed
renovate bot referenced this pull request in teutonet/teutonet-helm-charts Feb 27, 2024
#798)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [velero](https://togithub.com/vmware-tanzu/velero)
([source](https://togithub.com/vmware-tanzu/helm-charts)) | minor |
`5.3.0` -> `5.4.1` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>vmware-tanzu/helm-charts (velero)</summary>

###
[`v5.4.1`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-5.4.1)

[Compare
Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-5.4.0...velero-5.4.1)

A Helm chart for velero

#### What's Changed

- \[velero] Change default upload type to kopia by
[@&#8203;qiuming-best](https://togithub.com/qiuming-best) in
[https://github.com/vmware-tanzu/helm-charts/pull/551](https://togithub.com/vmware-tanzu/helm-charts/pull/551)

**Full Changelog**:
vmware-tanzu/helm-charts@velero-5.4.0...velero-5.4.1

###
[`v5.4.0`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-5.4.0)

[Compare
Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-5.3.0...velero-5.4.0)

A Helm chart for velero

#### What's Changed

- \[velero] CI test for K8s 1.28 + 1.29 by
[@&#8203;jenting](https://togithub.com/jenting) in
[https://github.com/vmware-tanzu/helm-charts/pull/541](https://togithub.com/vmware-tanzu/helm-charts/pull/541)
- \[velero] Added default operation timeout override by
[@&#8203;DreamingRaven](https://togithub.com/DreamingRaven) in
[https://github.com/vmware-tanzu/helm-charts/pull/546](https://togithub.com/vmware-tanzu/helm-charts/pull/546)

#### New Contributors

- [@&#8203;DreamingRaven](https://togithub.com/DreamingRaven) made their
first contribution in
[https://github.com/vmware-tanzu/helm-charts/pull/546](https://togithub.com/vmware-tanzu/helm-charts/pull/546)

**Full Changelog**:
vmware-tanzu/helm-charts@velero-5.3.0...velero-5.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/teutonet/teutonet-helm-charts).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIxMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Chris Werner Rau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

velero server flag for default item operation timeout
4 participants