-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: introduce CI workflow to verify the CRD folder #483
ci: introduce CI workflow to verify the CRD folder #483
Conversation
f1bb5dc
to
8cb7a06
Compare
Amazing work @tungbq 🤩 |
@tungbq |
The difference detected in the CI job due to this YAML block:
These come from the final block of each crds YAML, e.g: https://github.com/vmware-tanzu/helm-charts/blob/main/charts/velero/crds/backuprepositories.yaml#L101-L106 I don't know the root cause for it now. Much appreciated if I could get some help here. |
@tungbq |
Signed-off-by: Tung Bui <[email protected]>
Signed-off-by: Tung Bui <[email protected]>
Signed-off-by: ishuar <[email protected]> Signed-off-by: Tung Bui <[email protected]>
Signed-off-by: Tung Bui <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]> Signed-off-by: Tung Bui <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]> Signed-off-by: Tung Bui <[email protected]>
Signed-off-by: Tung Bui <[email protected]>
b4cb4b6
to
9eeee06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you @tungbq
Thanks for your amazing work! @tungbq |
Special notes for your reviewer:
Close #480
Introduce CI workflow to verify the CRD folder, this will do following:
velero
andkubectl
command to generate 2 YAML manifest filesThis was tested on my forked repo:
The workflow also collects the artifact YAML manifest files and the diff results:
Currently I set the trigger event to run on
workflow_dispatch
only. Let me know if we need to cover other trigger events based.Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[velero]
)