[helm chart] if using missmatched provider env var doesnt get set properly

[MaxRink]

What steps did you take and what happened:
im configuring configuration.provider to csi and configuration.backupStorageLocation.provider to aws
The access to the bucket fails as AWS_SHARED_CREDENTIALS_FILE doesnt get set, thus the credential lookup fails with

time="2021-05-26T18:25:19Z" level=error msg="Error getting backup store for this location" backupLocation=default controller=backup-sync error="rpc error: code = Unknown desc = NoCredentialProviders: no valid providers in chain. Deprecated.\n\tFor verbose messaging see aws.Config.CredentialsChainVerboseErrors" error.file="/go/src/velero-plugin-for-aws/velero-plugin-for-aws/volume_snapshotter.go:59" error.function=main.getSession logSource="pkg/controller/backup_sync_controller.go:175"

ive verified it, AWS_SHARED_CREDENTIALS_FILE isnt set inside the velero container
What did you expect to happen:
credential lookup works

Environment:

• helm version (use helm version): 3.6
• helm chart version and app version (use helm list -n <YOUR NAMESPACE>): 2.21.0
• Kubernetes version (use kubectl version): 1.20.7
• Kubernetes installer & version: capi

[jenting]

There is no provider called csi, please use aws instead.

I guess you want to use plugins aws and csi?

[MaxRink]

@jenting Than this page is clearly wrong: https://velero.io/docs/v1.6/supported-providers/

[jenting]

@MaxRink
Well, it's a bit hard to explain.

Generally, the configuration.provider is to provide a simple way to configure only once. Then you don't have to configure to backupStorageLocation.provider and volumeSnapshotLocation.provider if you're using public cloud provider aws/gcp/auzre/alibaba which supports the Object Store and Volume Snapshotter.

In your use case, I guess you'd want to use aws plugin for AWS S3 Object Store, and CSI plugin for Volume Snapshotter. For example:

helm install velero \
    --namespace=velero \
    --create-namespace \
    --set-file credentials.secretContents.cloud=credentials-velero \
    --set configuration.provider=aws \
    --set configuration.backupStorageLocation.name=default \
    --set configuration.backupStorageLocation.bucket=<bucket-name> \
    --set configuration.backupStorageLocation.config.region=<aws-region> \
    --set snapshotsEnabled=true \
    --set configuration.volumeSnapshotLocation.name=default \
    --set configuration.volumeSnapshotLocation.config.region=<aws-region> \
    --set initContainers[0].name=velero-plugin-for-aws \
    --set initContainers[0].image=velero/velero-plugin-for-aws:v1.2.0 \ 
    --set initContainers[0].volumeMounts[0].mountPath=/target \
    --set initContainers[0].volumeMounts[0].name=plugins \
    --set configuration.features=EnableCSI \
    --set initContainers[1].name=velero-plugin-for-csi \
    --set initContainers[1].image=velero/velero-plugin-for-csi:v0.1.2 \
    --set initContainers[1].volumeMounts[0].mountPath=/target \
    --set initContainers[1].volumeMounts[0].name=plugins \
    vmware-tanzu/velero

[jenting]

We deprecated the configuration.provider but configured the provider in each backup storage location as well as in each volume snapshot location. Here is the PR.

Closing it.