Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.provider as an requirement is confusing for new users and the deployment will fail #320

Closed
jensneuhaus opened this issue Nov 11, 2021 · 2 comments
Labels
enhancement New feature or request velero

Comments

@jensneuhaus
Copy link

What steps did you take and what happened:

Trying to deploy Velero without config.provider being set will not deploy anything. I expected that it still works with e.g. a config like the following, if one has two different providers:

configuration:

    backupStorageLocation:
      provider: aws
       ... 

    volumeSnapshotLocation:
      provider: digitalocean.com/velero

What did you expect to happen:

Clear description in values.yaml file, that the provider is required; a check for it or a better handling if it is not existing.

Anything else you would like to add:

The deployment was not created because of {{- if .Values.configuration.provider -}} check; so I did not have any logs and it was hard to find out what actually is the problem.

Environment:

  • helm version (use helm version): 3.7.1
  • helm chart version and app version: 2.26.1
  • Kubernetes version (use kubectl version): Server 1.21.5 (on Server)
  • Cloud provider or hardware configuration: Digital ocean
@jenting
Copy link
Collaborator

jenting commented Nov 12, 2021

Related to #269

@jenting jenting added enhancement New feature or request velero labels Nov 16, 2021
@jenting
Copy link
Collaborator

jenting commented Aug 3, 2023

We deprecated the configuration.provider but configured the provider in each backup storage location as well as in each volume snapshot location. Here is the PR.

Closing it.

@jenting jenting closed this as completed Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request velero
Projects
None yet
Development

No branches or pull requests

3 participants
@jensneuhaus @jenting and others