Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Correct metrics calculations #878

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Bugfix] Correct metrics calculations #878

wants to merge 3 commits into from

Conversation

kylesayrs
Copy link
Collaborator

@kylesayrs kylesayrs commented Oct 30, 2024 •
edited
Loading

Purpose

  • Fix metrics calculations to use gigabytes and megabytes rather than gibibytes and mebibytes

Changes

  • Use correct gigabyte and megabyte sizes in metrics calculations
  • Rename get_layer_size_bytes to get_layer_size_mb

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

@kylesayrs kylesayrs self-assigned this Oct 31, 2024
@kylesayrs kylesayrs changed the title Correct metrics calculations [Bugfix] Correct metrics calculations Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@horheynm horheynm Awaiting requested review from horheynm

@dsikka dsikka Awaiting requested review from dsikka

@rahul-tuli rahul-tuli Awaiting requested review from rahul-tuli

At least 2 approving reviews are required to merge this pull request.

Assignees

@kylesayrs kylesayrs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kylesayrs