Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FSDP utils cleanup #854

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

FSDP utils cleanup #854

wants to merge 3 commits into from

Conversation

kylesayrs
Copy link
Collaborator

Purpose

  • Code cleanup
  • Fix bug where FSDP and accelerate imports are coupled, meaning that not having one will cause the other's utils to fail

Changes

  • Decouple accelerate and fsdp imports
  • Use existing FSDP_WRAPPED_MODULE constant
  • General code cleanup and more detailed comment

@vllm-project vllm-project deleted a comment from github-actions bot Oct 19, 2024
@kylesayrs kylesayrs self-assigned this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kylesayrs kylesayrs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kylesayrs