Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v: add selector option unwrapping on if != none #22895

Merged
merged 8 commits into from
Nov 19, 2024
Merged

v: add selector option unwrapping on if != none #22895

merged 8 commits into from
Nov 19, 2024

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Nov 17, 2024 •
edited by huly-for-github bot
Loading

@felipensp felipensp changed the title v: add selector option unwraping on if != none v: add selector option unwrapping on if != none Nov 17, 2024
@felipensp felipensp marked this pull request as ready for review November 18, 2024 14:06
spytheman
spytheman approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 3d302a6 into vlang:master Nov 19, 2024
70 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cgen error - unwrapping an option field in a struct doesn't seem to unwrap it correctly
2 participants
@felipensp @spytheman