Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v: fix -skip-unused error with aggregate method call #22883

Merged
merged 2 commits into from
Nov 18, 2024
Merged

v: fix -skip-unused error with aggregate method call #22883

merged 2 commits into from
Nov 18, 2024

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Nov 17, 2024 •
edited by huly-for-github bot
Loading

@felipensp felipensp marked this pull request as ready for review November 17, 2024 10:17
spytheman
spytheman approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

Please also add a small example/test pair of .vv/.skip_unused.run.out files in vlib/v/tests/skip_unused/.

@felipensp
Copy link
Member Author

Excellent work.

Please also add a small example/test pair of .vv/.skip_unused.run.out files in vlib/v/tests/skip_unused/.

Test added.

@spytheman spytheman merged commit 983511f into vlang:master Nov 18, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building vsql with -skip-unused results in a missing pstr method
2 participants
@felipensp @spytheman