Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building vsql with -skip-unused results in a missing pstr method #22852

Closed
medvednikov opened this issue Nov 13, 2024 · 1 comment · Fixed by #22883
Closed

Building vsql with -skip-unused results in a missing pstr method #22852

medvednikov opened this issue Nov 13, 2024 · 1 comment · Fixed by #22883
Assignees
@felipensp
Labels
Bug This tag is applied to issues which reports bugs. Status: Confirmed This bug has been confirmed to be valid by a contributor.

Comments

@medvednikov
Copy link
Member

medvednikov commented Nov 13, 2024 •
edited
Loading

Describe the bug

Reformatted file: /home/runner/.vmodules/elliotchance/vsql/vsql/grammar.v
Compile vsql
builder error: 
================== C compilation error (from tcc): ==============
cc: /tmp/v_1001/vsql.01JCK1CANWDCQW0V9AKJ41HSBA.tmp.c:41730: warning: implicit declaration of function 'vsql__BooleanPredicand_pstr'
cc: /tmp/v_1001/vsql.01JCK1CANWDCQW0V9AKJ41HSBA.tmp.c:41730: error: type mismatch in conditional expression (have 'struct string' and 'int')
... (the original output was 3 lines long, and was truncated to 2 lines)
@medvednikov medvednikov added the Bug This tag is applied to issues which reports bugs. label Nov 13, 2024
@felipensp felipensp added the Status: Confirmed This bug has been confirmed to be valid by a contributor. label Nov 17, 2024
@felipensp felipensp self-assigned this Nov 17, 2024
@felipensp
Copy link
Member

It's related to method call on Aggregate type.

@felipensp felipensp mentioned this issue Nov 17, 2024
Merged
spytheman pushed a commit that referenced this issue Nov 18, 2024
@felipensp
v.markused: fix -skip-unused error with aggregate method call (fix #…
983511f 
…22852 - building vsql) (#22883)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipensp felipensp

Labels
Bug This tag is applied to issues which reports bugs. Status: Confirmed This bug has been confirmed to be valid by a contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v: fix -skip-unused error with aggregate method call felipensp/v
2 participants
@medvednikov @felipensp