Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support visibility to concatenate macro #28

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

hatoo
Copy link
Contributor

@hatoo hatoo commented Apr 8, 2024

Fix #19
Hi, thanks for building such an amazing crate!

I also want to concatenate! can be expanded to pub struct.
And I've realized that it can be done by small changes.

@vks
Copy link
Owner

vks commented Apr 26, 2024

Thanks for the PR, this change makes a lot of sense! I would still like to test that the macro works without pub, but that can be added later.

@vks vks merged commit ca4859e into vks:master Apr 26, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

concatenate! macro cannot expand to public type
2 participants