Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): support diff.printBasicPrototype, Adding possibility to get rid of prototypes from the output #6504

Closed
wants to merge 12 commits into from

Conversation

spamshaker
Copy link
Contributor

@spamshaker spamshaker commented Sep 14, 2024

Description

simplifies copying output to apply result in unit test

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

spamshaker and others added 4 commits September 14, 2024 09:46
Adding possibility to get rid of printing prototype in diff output
Added a new configuration option `printBasicPrototype` to the diff section. This allows users to set the pretty-format option for the diff output, with a default value of `true`.
Copy link

netlify bot commented Sep 14, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 18d14e8
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6733f6b099055b000851681a
😎 Deploy Preview https://deploy-preview-6504--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa changed the title feat: Adding possibility to get rid of prototypes from the output feat(utils): support diff.printBasicPrototype, Adding possibility to get rid of prototypes from the output Oct 20, 2024
hi-ogawa
hi-ogawa previously approved these changes Oct 20, 2024
@hi-ogawa hi-ogawa added this to the 2.2.0 milestone Oct 30, 2024
hi-ogawa pushed a commit to hi-ogawa/vitest that referenced this pull request Nov 13, 2024
Update index.ts

Adding possibility to get rid of printing prototype in diff output

Update types.ts

Update config documentation to include diff.printBasicPrototype

Added a new configuration option `printBasicPrototype` to the diff section. This allows users to set the pretty-format option for the diff output, with a default value of `true`.

Update index.ts

CR Fixes

test: add test

chore: type error

chore: lint

test: fix threshold test

chore: lint
@hi-ogawa
Copy link
Contributor

Closing this PR as I merged your commits into #6740 and fixed conflicts early. Thanks for the contribution!

@hi-ogawa hi-ogawa closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants