Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support inline diff options and support printBasicPrototype #6740

Merged
merged 17 commits into from
Nov 13, 2024

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Oct 18, 2024

Description

todo

  • test
  • cli
  • docs

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 172b985
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6733fe5419f798000807d0f7
😎 Deploy Preview https://deploy-preview-6740--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa marked this pull request as ready for review October 19, 2024 05:15
sheremet-va
sheremet-va previously approved these changes Oct 20, 2024
docs/config/index.md Outdated Show resolved Hide resolved
hi-ogawa and others added 4 commits October 21, 2024 08:26
Update index.ts

Adding possibility to get rid of printing prototype in diff output

Update types.ts

Update config documentation to include diff.printBasicPrototype

Added a new configuration option `printBasicPrototype` to the diff section. This allows users to set the pretty-format option for the diff output, with a default value of `true`.

Update index.ts

CR Fixes

test: add test

chore: type error

chore: lint

test: fix threshold test

chore: lint
@hi-ogawa hi-ogawa changed the title feat(vitest): support inline diff options feat: support inline diff options and support printBasicPrototype Nov 13, 2024
@hi-ogawa
Copy link
Contributor Author

I cherry-picked #6504 in this branch since merge conflict was imminent. This should make v2.2.0 process easier.

@sheremet-va sheremet-va merged commit 391860f into vitest-dev:main Nov 13, 2024
17 checks passed
@hi-ogawa hi-ogawa deleted the feat-diff-options-inline branch November 13, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't expand large diffs by default
3 participants