feat: enable "unitRounding" by default

vintl-dev · Oct 13, 2023 · c56f6fb · c56f6fb
1 parent 803439b
commit c56f6fb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 17 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -208,12 +208,7 @@ export interface FormatOptions extends FormatRelativeTimeOptions {
    * hour"`. Otherwise, the result of 60 minutes will be returned as is — `"60
    * minutes"`.
    *
-   * By default, this option is disabled (`false`) when the `roundingMode` is
-   * set to `null`, but enabled (`true`) otherwise. This will change in the next
-   * major update, in which this option will always be enabled (`true`) by
-   * default, regardless of the `roundingMode`.
-   *
-   * @default false / true // Depends on the roundingMode
+   * @default true
    */
   unitRounding?: boolean
 }
@@ -373,8 +368,8 @@ function getRoundingMethod({ roundingMode }: FormatOptions) {
   return roundingModesImpls[roundingMode]
 }
 
-function shouldUseUnitRounding({ unitRounding, roundingMode }: FormatOptions) {
-  unitRounding ??= (roundingMode ?? null) !== null
+function shouldUseUnitRounding({ unitRounding }: FormatOptions) {
+  unitRounding ??= true
   if (typeof unitRounding !== 'boolean') {
     throwRangeError('unitRounding', unitRounding)
   }

diff --git a/test/index.test.ts b/test/index.test.ts
@@ -156,37 +156,35 @@ test('formatTimeDifference (halfCeil rounding method)', () => {
   ).toMatchInlineSnapshot('"через 3 роки"')
 })
 
-test('formatTimeDifference (with unitRounding)', () => {
+test('formatTimeDifference (without unitRounding)', () => {
   const fiftyNineSthnMinutesAgo = now - 59.6 * minute
   const twentyThreeSthnHoursInFuture = now + 23.5 * hour
 
   expect(
     ago(fiftyNineSthnMinutesAgo, {
       roundingMode: 'halfExpand',
-      unitRounding: false,
     }),
-  ).toMatchInlineSnapshot('"60 хвилин тому"')
+  ).toMatchInlineSnapshot('"1 годину тому"')
 
   expect(
     ago(twentyThreeSthnHoursInFuture, {
       roundingMode: 'halfExpand',
-      unitRounding: false,
     }),
-  ).toMatchInlineSnapshot('"через 24 години"')
+  ).toMatchInlineSnapshot('"завтра"')
 
   expect(
     ago(fiftyNineSthnMinutesAgo, {
       roundingMode: 'halfExpand',
-      unitRounding: true,
+      unitRounding: false,
     }),
-  ).toMatchInlineSnapshot('"1 годину тому"')
+  ).toMatchInlineSnapshot('"60 хвилин тому"')
 
   expect(
     ago(twentyThreeSthnHoursInFuture, {
       roundingMode: 'halfExpand',
-      unitRounding: true,
+      unitRounding: false,
     }),
-  ).toMatchInlineSnapshot('"завтра"')
+  ).toMatchInlineSnapshot('"через 24 години"')
 })
 
 // TODO: more tests + coverage